diff options
| author | Alon Zakai <azakai@google.com> | 2020-08-11 10:31:51 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-08-11 10:31:51 -0700 |
| commit | f067a45c1e88124173af992e66a7125fe6ab366a (patch) | |
| tree | 769d3079cb03a59b5c6689dd1879db404fb61551 /test/unit | |
| parent | 454a1cb0b90397593472b9dd31c5418e23c40be3 (diff) | |
| download | binaryen-f067a45c1e88124173af992e66a7125fe6ab366a.tar.gz binaryen-f067a45c1e88124173af992e66a7125fe6ab366a.tar.bz2 binaryen-f067a45c1e88124173af992e66a7125fe6ab366a.zip | |
Skip tests that fail on windows and enable all the rest (#3035)
This lets us run most tests at least on that platform.
Add a new function for skipping those tests, skip_if_on_windows,
so that it's easy to find which tests are disabled on windows for later fixing
efforts.
This fixes a few minor issues for windows, like comparisons
should ignore \r in some cases.
Rename all passes tests that use --dwarfdump to contain "dwarf"
in their name, which makes it easy to skip those (and is clearer
anyhow).
Diffstat (limited to 'test/unit')
| -rw-r--r-- | test/unit/test_asyncify.py | 2 | ||||
| -rw-r--r-- | test/unit/test_features.py | 2 | ||||
| -rw-r--r-- | test/unit/utils.py | 7 |
3 files changed, 9 insertions, 2 deletions
diff --git a/test/unit/test_asyncify.py b/test/unit/test_asyncify.py index 55b198cbb..1010c07c4 100644 --- a/test/unit/test_asyncify.py +++ b/test/unit/test_asyncify.py @@ -29,7 +29,7 @@ class AsyncifyTest(utils.BinaryenTestCase): shared.run_process(shared.WASM_DIS + ['a.wasm', '-o', 'a.wat']) output = shared.run_process(shared.WASM_SHELL + ['a.wat'], capture_output=True).stdout with open(self.input_path('asyncify-pure.txt'), 'r') as f: - self.assertEqual(f.read(), output) + self.assert_equal_ignoring_line_endings(f.read(), output) # test wat input wat = self.input_path('asyncify-pure.wat') diff --git a/test/unit/test_features.py b/test/unit/test_features.py index 3b30595d6..506fd8809 100644 --- a/test/unit/test_features.py +++ b/test/unit/test_features.py @@ -354,4 +354,4 @@ class TargetFeaturesSectionTest(utils.BinaryenTestCase): '--enable-tail-call', '--enable-reference-types', '--enable-multivalue' - ], p2.stdout.split()) + ], p2.stdout.splitlines()) diff --git a/test/unit/utils.py b/test/unit/utils.py index a9bfc3740..d91141e36 100644 --- a/test/unit/utils.py +++ b/test/unit/utils.py @@ -36,3 +36,10 @@ class BinaryenTestCase(unittest.TestCase): self.assertEqual(p.stderr, '') self.assertEqual(p.stdout.split('\n')[:-1], ['--enable-' + f for f in features]) + + # similar to assertEqual, but while ignoring line ending differences such + # as those between windows and unix + def assert_equal_ignoring_line_endings(self, left, right): + left = left.replace('\r\n', '\n') + right = right.replace('\r\n', '\n') + self.assertEqual(left, right) |