diff options
author | Alon Zakai <azakai@google.com> | 2022-08-22 13:53:47 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-08-22 13:53:47 -0700 |
commit | 38c084ee386e257389d44c6200a403f74432e1af (patch) | |
tree | 8e41abd3ad903b9fcb426bf0c4be3dd66a092247 /test/unreachable-code.wast.fromBinary | |
parent | b24df4d0c4705027fdc6e261aa3f8e4f61dc5c0a (diff) | |
download | binaryen-38c084ee386e257389d44c6200a403f74432e1af.tar.gz binaryen-38c084ee386e257389d44c6200a403f74432e1af.tar.bz2 binaryen-38c084ee386e257389d44c6200a403f74432e1af.zip |
Avoid adding new unneeded names to blocks in text roundtripping (#4943)
Previously the wat parser would turn this input:
(block
(nop)
)
into something like this:
(block $block17
(nop)
)
It just added a name all the time, in case the block is referred to by an index
later even though it doesn't have a name.
This PR makes us rountrip more precisely by not adding such names: if there
was no name before, and there is no break by index, then do not add a name.
In addition, this will be useful for non-nullable locals since whether a block has
a name or not matters there. Like #4912, this makes us more regular in our
usage of block names.
Diffstat (limited to 'test/unreachable-code.wast.fromBinary')
-rw-r--r-- | test/unreachable-code.wast.fromBinary | 18 |
1 files changed, 7 insertions, 11 deletions
diff --git a/test/unreachable-code.wast.fromBinary b/test/unreachable-code.wast.fromBinary index a93ffe730..67b8c30a6 100644 --- a/test/unreachable-code.wast.fromBinary +++ b/test/unreachable-code.wast.fromBinary @@ -44,22 +44,18 @@ ) (func $a-block-prepost (nop) - (block $label$1 - (if - (i32.const 1) - (unreachable) - ) + (if + (i32.const 1) + (unreachable) ) (nop) ) (func $b-block-prepost (nop) - (block $label$1 - (if - (i32.const 1) - (unreachable) - (unreachable) - ) + (if + (i32.const 1) + (unreachable) + (unreachable) ) ) (func $recurse |