wasm2js: Do not convert x >>> 0 | 0 to x >>> 0 (#2581)

isBinary was used where we should only accept
a signed binary, as removing the | 0 from an unsigned
value may be incorrect.

This does regress a few small things (as can be seen
in the diff). If it's important we can add more sophisticated
optimizations here, perhaps like an assumption that the
signedness of a local never matters.

Fixes emscripten-core/emscripten#10173

1 files changed, 8 insertions, 8 deletions

diff --git a/test/wasm2js/i64-rotate.2asm.js.opt b/test/wasm2js/i64-rotate.2asm.js.opt
index 69fefab76..a3e2091fc 100644
--- a/test/wasm2js/i64-rotate.2asm.js.opt
+++ b/test/wasm2js/i64-rotate.2asm.js.opt
@@ -35,9 +35,9 @@ function asmFunc(global, env, buffer) {
   $5 = $6;
   $3 = $5 & 31;
   if (32 <= $5 >>> 0) {
-   $3 = -1 >>> $3
+   $3 = -1 >>> $3 | 0
   } else {
-   $4 = -1 >>> $3;
+   $4 = -1 >>> $3 | 0;
    $3 = (1 << $3) - 1 << 32 - $3 | -1 >>> $3;
   }
   $5 = $3 & $0;
@@ -66,9 +66,9 @@ function asmFunc(global, env, buffer) {
   $1 = $4 & 31;
   if (32 <= $4 >>> 0) {
    $2 = 0;
-   $0 = $3 >>> $1;
+   $0 = $3 >>> $1 | 0;
   } else {
-   $2 = $3 >>> $1;
+   $2 = $3 >>> $1 | 0;
    $0 = ((1 << $1) - 1 & $3) << 32 - $1 | $0 >>> $1;
   }
   $0 = $0 | $6;
@@ -92,9 +92,9 @@ function asmFunc(global, env, buffer) {
   $5 = $6 & 31;
   if (32 <= $6 >>> 0) {
    $4 = 0;
-   $6 = $3 >>> $5;
+   $6 = $3 >>> $5 | 0;
   } else {
-   $4 = $3 >>> $5;
+   $4 = $3 >>> $5 | 0;
    $6 = ((1 << $5) - 1 & $3) << 32 - $5 | $7 >>> $5;
   }
   $7 = $4;
@@ -102,9 +102,9 @@ function asmFunc(global, env, buffer) {
   $5 = $3 & 31;
   if (32 <= $3 >>> 0) {
    $4 = 0;
-   $2 = -1 >>> $5;
+   $2 = -1 >>> $5 | 0;
   } else {
-   $4 = -1 >>> $5;
+   $4 = -1 >>> $5 | 0;
    $2 = (1 << $5) - 1 << 32 - $5 | -1 >>> $5;
   }
   $0 = $2 & $0;