diff options
| author | Alon Zakai <azakai@google.com> | 2024-09-10 09:54:51 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-09-10 09:54:51 -0700 |
| commit | 203dcd5c47d6ea784e613f647f8addd9815a3d5b (patch) | |
| tree | 1212721bf13e0cc945ac5fea9c559ab00f129779 /test | |
| parent | 2467e70524c96481c34e5ac23b9f068eb60abcbf (diff) | |
| download | binaryen-203dcd5c47d6ea784e613f647f8addd9815a3d5b.tar.gz binaryen-203dcd5c47d6ea784e613f647f8addd9815a3d5b.tar.bz2 binaryen-203dcd5c47d6ea784e613f647f8addd9815a3d5b.zip | |
[NFC-ish] Remove LocalGraph from LocalSubtyping (#6921)
The LocalGraph there was used for two purposes:
1. Get the list of gets and sets.
2. Get only the reachable gets and sets.
It is trivial to get all the gets and sets in a much faster way, by just walking the
code as this PR does. The downside is that we also consider unreachable gets
and sets, so unreachable code can prevent us from optimizing, but that seems
worthwhile as many passes make that assumption (and they all become
maximally effective after --dce). That is the only non-NFC part here.
Removing LocalGraph + the fixup code for unreachability makes this
significantly shorter, and also 2-3x faster.
Diffstat (limited to 'test')
| -rw-r--r-- | test/lit/passes/local-subtyping.wast | 23 |
1 files changed, 6 insertions, 17 deletions
diff --git a/test/lit/passes/local-subtyping.wast b/test/lit/passes/local-subtyping.wast index 922d350c5..d5fc3d63d 100644 --- a/test/lit/passes/local-subtyping.wast +++ b/test/lit/passes/local-subtyping.wast @@ -397,28 +397,18 @@ ) ;; CHECK: (func $incompatible-sets (type $1) (result i32) - ;; CHECK-NEXT: (local $temp (ref $1)) + ;; CHECK-NEXT: (local $temp (ref null $1)) ;; CHECK-NEXT: (local.set $temp ;; CHECK-NEXT: (ref.func $incompatible-sets) ;; CHECK-NEXT: ) ;; CHECK-NEXT: (unreachable) ;; CHECK-NEXT: (drop ;; CHECK-NEXT: (local.tee $temp - ;; CHECK-NEXT: (block - ;; CHECK-NEXT: (drop - ;; CHECK-NEXT: (ref.null nofunc) - ;; CHECK-NEXT: ) - ;; CHECK-NEXT: (unreachable) - ;; CHECK-NEXT: ) + ;; CHECK-NEXT: (ref.null nofunc) ;; CHECK-NEXT: ) ;; CHECK-NEXT: ) - ;; CHECK-NEXT: (local.tee $temp - ;; CHECK-NEXT: (block - ;; CHECK-NEXT: (drop - ;; CHECK-NEXT: (ref.null nofunc) - ;; CHECK-NEXT: ) - ;; CHECK-NEXT: (unreachable) - ;; CHECK-NEXT: ) + ;; CHECK-NEXT: (local.set $temp + ;; CHECK-NEXT: (ref.null nofunc) ;; CHECK-NEXT: ) ;; CHECK-NEXT: (unreachable) ;; CHECK-NEXT: ) @@ -431,9 +421,8 @@ ;; Make all code unreachable from here. (unreachable) ;; In unreachable code, assign values that are not compatible with the more - ;; specific type we will optimize to. Those cannot be left as they are, and - ;; will be fixed up so that they validate. (All we need is validation, as - ;; their contents do not matter, given they are not reached.) + ;; specific type we will optimize to. This prevents optimization here (we + ;; will optimize better after --dce is run). (drop (local.tee $temp (ref.null func) |