summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorAlon Zakai <azakai@google.com>2023-03-17 11:01:12 -0700
committerGitHub <noreply@github.com>2023-03-17 11:01:12 -0700
commit69ff3bf4f10d1f50343a3db7e4730b576f679c70 (patch)
tree1481214262da0e13e8a517a23bcb63a8ba99f055 /test
parentecbebfbee12f2f25af648119604915fc37427f6f (diff)
downloadbinaryen-69ff3bf4f10d1f50343a3db7e4730b576f679c70.tar.gz
binaryen-69ff3bf4f10d1f50343a3db7e4730b576f679c70.tar.bz2
binaryen-69ff3bf4f10d1f50343a3db7e4730b576f679c70.zip
[Wasm GC] Allow extern.externalize in globals (#5585)
This fixes wasm-ctor-eval on evalling a GC data structure that contains a field initialized with an externalized value. Per the spec this is a constant instruction and I verified that V8 allows this. Also add missing validation in wasm-ctor-eval of the output (which makes debugging this kind of thing a little easier).
Diffstat (limited to 'test')
-rw-r--r--test/lit/ctor-eval/extern.wast32
1 files changed, 31 insertions, 1 deletions
diff --git a/test/lit/ctor-eval/extern.wast b/test/lit/ctor-eval/extern.wast
index 1bd738380..462e64290 100644
--- a/test/lit/ctor-eval/extern.wast
+++ b/test/lit/ctor-eval/extern.wast
@@ -1,22 +1,37 @@
;; NOTE: Assertions have been generated by update_lit_checks.py --all-items and should not be edited.
-;; RUN: wasm-ctor-eval %s --ctors=test1,test2 --kept-exports=test1,test2 --quiet -all -S -o - | filecheck %s
+;; RUN: wasm-ctor-eval %s --ctors=test1,test2,test3 --kept-exports=test1,test2,test3 --quiet -all -S -o - | filecheck %s
(module
;; CHECK: (type $array (array (mut i8)))
(type $array (array (mut i8)))
+ ;; CHECK: (type $struct (struct (field externref)))
+ (type $struct (struct (field externref)))
+
;; CHECK: (type $none_=>_externref (func (result externref)))
+ ;; CHECK: (type $none_=>_anyref (func (result anyref)))
+
;; CHECK: (global $ctor-eval$global (ref $array) (array.new_fixed $array
;; CHECK-NEXT: (i32.const 1)
;; CHECK-NEXT: (i32.const 2)
;; CHECK-NEXT: (i32.const 3)
;; CHECK-NEXT: ))
+ ;; CHECK: (global $ctor-eval$global_0 (ref $struct) (struct.new $struct
+ ;; CHECK-NEXT: (extern.externalize
+ ;; CHECK-NEXT: (i31.new
+ ;; CHECK-NEXT: (i32.const 1)
+ ;; CHECK-NEXT: )
+ ;; CHECK-NEXT: )
+ ;; CHECK-NEXT: ))
+
;; CHECK: (export "test1" (func $test1_0))
(export "test1" (func $test1))
;; CHECK: (export "test2" (func $test2_0))
(export "test2" (func $test2))
+ ;; CHECK: (export "test3" (func $test3_0))
+ (export "test3" (func $test3))
(func $test1 (result externref)
;; This will remain almost the same, even though we eval it, since the
@@ -42,6 +57,17 @@
)
)
)
+
+ (func $test3 (result anyref)
+ ;; This will add a global that contains an externalization operation.
+ (struct.new $struct
+ (extern.externalize
+ (i31.new
+ (i32.const 1)
+ )
+ )
+ )
+ )
)
;; CHECK: (func $test1_0 (type $none_=>_externref) (result externref)
@@ -57,3 +83,7 @@
;; CHECK-NEXT: (global.get $ctor-eval$global)
;; CHECK-NEXT: )
;; CHECK-NEXT: )
+
+;; CHECK: (func $test3_0 (type $none_=>_anyref) (result anyref)
+;; CHECK-NEXT: (global.get $ctor-eval$global_0)
+;; CHECK-NEXT: )