Add bulk-memory-opt feature and ignore call-indirect-overlong (#7139)

LLVM recently split the bulk-memory-opt feature out from bulk-memory,
containing just memory.copy and memory.fill. This change follows that,
making bulk-memory-opt also enabled when all of bulk-memory is enabled.

It also introduces call-indirect-overlong following LLVM, but ignores
it, since Binaryen has always allowed the encoding (i.e. command
line flags enabling or disabling the feature are accepted but
ignored).

16 files changed, 164 insertions, 6 deletions

diff --git a/test/binaryen.js/kitchen-sink.js.txt b/test/binaryen.js/kitchen-sink.js.txt
index d38c16857..637b1ab95 100644
--- a/test/binaryen.js/kitchen-sink.js.txt
+++ b/test/binaryen.js/kitchen-sink.js.txt
@@ -33,7 +33,7 @@ Features.RelaxedSIMD: 4096
 Features.ExtendedConst: 8192
 Features.Strings: 16384
 Features.MultiMemory: 32768
-Features.All: 524287
+Features.All: 2097151
 InvalidId: 0
 BlockId: 1
 IfId: 2
diff --git a/test/example/c-api-kitchen-sink.txt b/test/example/c-api-kitchen-sink.txt
index 8a5b6dc87..d3e6a6767 100644
--- a/test/example/c-api-kitchen-sink.txt
+++ b/test/example/c-api-kitchen-sink.txt
@@ -47,7 +47,7 @@ BinaryenFeatureMemory64: 2048
 BinaryenFeatureRelaxedSIMD: 4096
 BinaryenFeatureExtendedConst: 8192
 BinaryenFeatureStrings: 16384
-BinaryenFeatureAll: 524287
+BinaryenFeatureAll: 2097151
 (f32.neg
  (f32.const -33.61199951171875)
 )
diff --git a/test/lit/help/wasm-as.test b/test/lit/help/wasm-as.test
index 5dd4b1515..7f2e1bc94 100644
--- a/test/lit/help/wasm-as.test
+++ b/test/lit/help/wasm-as.test
@@ -64,6 +64,18 @@
 ;; CHECK-NEXT:
 ;; CHECK-NEXT:   --disable-bulk-memory                Disable bulk memory operations
 ;; CHECK-NEXT:
+;; CHECK-NEXT:   --enable-bulk-memory-opt             Enable memory.copy and memory.fill
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --disable-bulk-memory-opt            Disable memory.copy and memory.fill
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --enable-call-indirect-overlong      Enable LEB encoding of call-indirect
+;; CHECK-NEXT:                                        (Ignored for compatibility as it has no
+;; CHECK-NEXT:                                        effect on Binaryen)
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --disable-call-indirect-overlong     Disable LEB encoding of call-indirect
+;; CHECK-NEXT:                                        (Ignored for compatibility as it has no
+;; CHECK-NEXT:                                        effect on Binaryen)
+;; CHECK-NEXT:
 ;; CHECK-NEXT:   --enable-exception-handling          Enable exception handling operations
 ;; CHECK-NEXT:
 ;; CHECK-NEXT:   --disable-exception-handling         Disable exception handling operations
diff --git a/test/lit/help/wasm-ctor-eval.test b/test/lit/help/wasm-ctor-eval.test
index abb80b12e..06e2c4a0d 100644
--- a/test/lit/help/wasm-ctor-eval.test
+++ b/test/lit/help/wasm-ctor-eval.test
@@ -71,6 +71,18 @@
 ;; CHECK-NEXT:
 ;; CHECK-NEXT:   --disable-bulk-memory                Disable bulk memory operations
 ;; CHECK-NEXT:
+;; CHECK-NEXT:   --enable-bulk-memory-opt             Enable memory.copy and memory.fill
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --disable-bulk-memory-opt            Disable memory.copy and memory.fill
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --enable-call-indirect-overlong      Enable LEB encoding of call-indirect
+;; CHECK-NEXT:                                        (Ignored for compatibility as it has no
+;; CHECK-NEXT:                                        effect on Binaryen)
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --disable-call-indirect-overlong     Disable LEB encoding of call-indirect
+;; CHECK-NEXT:                                        (Ignored for compatibility as it has no
+;; CHECK-NEXT:                                        effect on Binaryen)
+;; CHECK-NEXT:
 ;; CHECK-NEXT:   --enable-exception-handling          Enable exception handling operations
 ;; CHECK-NEXT:
 ;; CHECK-NEXT:   --disable-exception-handling         Disable exception handling operations
diff --git a/test/lit/help/wasm-dis.test b/test/lit/help/wasm-dis.test
index 90bc12b99..d698afe86 100644
--- a/test/lit/help/wasm-dis.test
+++ b/test/lit/help/wasm-dis.test
@@ -57,6 +57,18 @@
 ;; CHECK-NEXT:
 ;; CHECK-NEXT:   --disable-bulk-memory                Disable bulk memory operations
 ;; CHECK-NEXT:
+;; CHECK-NEXT:   --enable-bulk-memory-opt             Enable memory.copy and memory.fill
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --disable-bulk-memory-opt            Disable memory.copy and memory.fill
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --enable-call-indirect-overlong      Enable LEB encoding of call-indirect
+;; CHECK-NEXT:                                        (Ignored for compatibility as it has no
+;; CHECK-NEXT:                                        effect on Binaryen)
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --disable-call-indirect-overlong     Disable LEB encoding of call-indirect
+;; CHECK-NEXT:                                        (Ignored for compatibility as it has no
+;; CHECK-NEXT:                                        effect on Binaryen)
+;; CHECK-NEXT:
 ;; CHECK-NEXT:   --enable-exception-handling          Enable exception handling operations
 ;; CHECK-NEXT:
 ;; CHECK-NEXT:   --disable-exception-handling         Disable exception handling operations
diff --git a/test/lit/help/wasm-emscripten-finalize.test b/test/lit/help/wasm-emscripten-finalize.test
index cdd378d40..5f9f17ff2 100644
--- a/test/lit/help/wasm-emscripten-finalize.test
+++ b/test/lit/help/wasm-emscripten-finalize.test
@@ -99,6 +99,18 @@
 ;; CHECK-NEXT:
 ;; CHECK-NEXT:   --disable-bulk-memory                Disable bulk memory operations
 ;; CHECK-NEXT:
+;; CHECK-NEXT:   --enable-bulk-memory-opt             Enable memory.copy and memory.fill
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --disable-bulk-memory-opt            Disable memory.copy and memory.fill
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --enable-call-indirect-overlong      Enable LEB encoding of call-indirect
+;; CHECK-NEXT:                                        (Ignored for compatibility as it has no
+;; CHECK-NEXT:                                        effect on Binaryen)
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --disable-call-indirect-overlong     Disable LEB encoding of call-indirect
+;; CHECK-NEXT:                                        (Ignored for compatibility as it has no
+;; CHECK-NEXT:                                        effect on Binaryen)
+;; CHECK-NEXT:
 ;; CHECK-NEXT:   --enable-exception-handling          Enable exception handling operations
 ;; CHECK-NEXT:
 ;; CHECK-NEXT:   --disable-exception-handling         Disable exception handling operations
diff --git a/test/lit/help/wasm-merge.test b/test/lit/help/wasm-merge.test
index ee1fed13a..f83fc5c0f 100644
--- a/test/lit/help/wasm-merge.test
+++ b/test/lit/help/wasm-merge.test
@@ -87,6 +87,18 @@
 ;; CHECK-NEXT:
 ;; CHECK-NEXT:   --disable-bulk-memory                Disable bulk memory operations
 ;; CHECK-NEXT:
+;; CHECK-NEXT:   --enable-bulk-memory-opt             Enable memory.copy and memory.fill
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --disable-bulk-memory-opt            Disable memory.copy and memory.fill
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --enable-call-indirect-overlong      Enable LEB encoding of call-indirect
+;; CHECK-NEXT:                                        (Ignored for compatibility as it has no
+;; CHECK-NEXT:                                        effect on Binaryen)
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --disable-call-indirect-overlong     Disable LEB encoding of call-indirect
+;; CHECK-NEXT:                                        (Ignored for compatibility as it has no
+;; CHECK-NEXT:                                        effect on Binaryen)
+;; CHECK-NEXT:
 ;; CHECK-NEXT:   --enable-exception-handling          Enable exception handling operations
 ;; CHECK-NEXT:
 ;; CHECK-NEXT:   --disable-exception-handling         Disable exception handling operations
diff --git a/test/lit/help/wasm-metadce.test b/test/lit/help/wasm-metadce.test
index e98834641..0be234ac7 100644
--- a/test/lit/help/wasm-metadce.test
+++ b/test/lit/help/wasm-metadce.test
@@ -699,6 +699,22 @@
 ;; CHECK-NEXT:
 ;; CHECK-NEXT:   --disable-bulk-memory                         Disable bulk memory operations
 ;; CHECK-NEXT:
+;; CHECK-NEXT:   --enable-bulk-memory-opt                      Enable memory.copy and
+;; CHECK-NEXT:                                                 memory.fill
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --disable-bulk-memory-opt                     Disable memory.copy and
+;; CHECK-NEXT:                                                 memory.fill
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --enable-call-indirect-overlong               Enable LEB encoding of
+;; CHECK-NEXT:                                                 call-indirect (Ignored for
+;; CHECK-NEXT:                                                 compatibility as it has no
+;; CHECK-NEXT:                                                 effect on Binaryen)
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --disable-call-indirect-overlong              Disable LEB encoding of
+;; CHECK-NEXT:                                                 call-indirect (Ignored for
+;; CHECK-NEXT:                                                 compatibility as it has no
+;; CHECK-NEXT:                                                 effect on Binaryen)
+;; CHECK-NEXT:
 ;; CHECK-NEXT:   --enable-exception-handling                   Enable exception handling
 ;; CHECK-NEXT:                                                 operations
 ;; CHECK-NEXT:
diff --git a/test/lit/help/wasm-opt.test b/test/lit/help/wasm-opt.test
index 06a9e5e84..630a64588 100644
--- a/test/lit/help/wasm-opt.test
+++ b/test/lit/help/wasm-opt.test
@@ -708,6 +708,22 @@
 ;; CHECK-NEXT:
 ;; CHECK-NEXT:   --disable-bulk-memory                         Disable bulk memory operations
 ;; CHECK-NEXT:
+;; CHECK-NEXT:   --enable-bulk-memory-opt                      Enable memory.copy and
+;; CHECK-NEXT:                                                 memory.fill
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --disable-bulk-memory-opt                     Disable memory.copy and
+;; CHECK-NEXT:                                                 memory.fill
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --enable-call-indirect-overlong               Enable LEB encoding of
+;; CHECK-NEXT:                                                 call-indirect (Ignored for
+;; CHECK-NEXT:                                                 compatibility as it has no
+;; CHECK-NEXT:                                                 effect on Binaryen)
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --disable-call-indirect-overlong              Disable LEB encoding of
+;; CHECK-NEXT:                                                 call-indirect (Ignored for
+;; CHECK-NEXT:                                                 compatibility as it has no
+;; CHECK-NEXT:                                                 effect on Binaryen)
+;; CHECK-NEXT:
 ;; CHECK-NEXT:   --enable-exception-handling                   Enable exception handling
 ;; CHECK-NEXT:                                                 operations
 ;; CHECK-NEXT:
diff --git a/test/lit/help/wasm-reduce.test b/test/lit/help/wasm-reduce.test
index cc75aed2b..d02d46fd7 100644
--- a/test/lit/help/wasm-reduce.test
+++ b/test/lit/help/wasm-reduce.test
@@ -93,6 +93,18 @@
 ;; CHECK-NEXT:
 ;; CHECK-NEXT:   --disable-bulk-memory                Disable bulk memory operations
 ;; CHECK-NEXT:
+;; CHECK-NEXT:   --enable-bulk-memory-opt             Enable memory.copy and memory.fill
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --disable-bulk-memory-opt            Disable memory.copy and memory.fill
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --enable-call-indirect-overlong      Enable LEB encoding of call-indirect
+;; CHECK-NEXT:                                        (Ignored for compatibility as it has no
+;; CHECK-NEXT:                                        effect on Binaryen)
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --disable-call-indirect-overlong     Disable LEB encoding of call-indirect
+;; CHECK-NEXT:                                        (Ignored for compatibility as it has no
+;; CHECK-NEXT:                                        effect on Binaryen)
+;; CHECK-NEXT:
 ;; CHECK-NEXT:   --enable-exception-handling          Enable exception handling operations
 ;; CHECK-NEXT:
 ;; CHECK-NEXT:   --disable-exception-handling         Disable exception handling operations
diff --git a/test/lit/help/wasm-split.test b/test/lit/help/wasm-split.test
index e5e736562..04d741421 100644
--- a/test/lit/help/wasm-split.test
+++ b/test/lit/help/wasm-split.test
@@ -196,6 +196,18 @@
 ;; CHECK-NEXT:
 ;; CHECK-NEXT:   --disable-bulk-memory                Disable bulk memory operations
 ;; CHECK-NEXT:
+;; CHECK-NEXT:   --enable-bulk-memory-opt             Enable memory.copy and memory.fill
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --disable-bulk-memory-opt            Disable memory.copy and memory.fill
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --enable-call-indirect-overlong      Enable LEB encoding of call-indirect
+;; CHECK-NEXT:                                        (Ignored for compatibility as it has no
+;; CHECK-NEXT:                                        effect on Binaryen)
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --disable-call-indirect-overlong     Disable LEB encoding of call-indirect
+;; CHECK-NEXT:                                        (Ignored for compatibility as it has no
+;; CHECK-NEXT:                                        effect on Binaryen)
+;; CHECK-NEXT:
 ;; CHECK-NEXT:   --enable-exception-handling          Enable exception handling operations
 ;; CHECK-NEXT:
 ;; CHECK-NEXT:   --disable-exception-handling         Disable exception handling operations
diff --git a/test/lit/help/wasm2js.test b/test/lit/help/wasm2js.test
index 50e229a1d..a326c75db 100644
--- a/test/lit/help/wasm2js.test
+++ b/test/lit/help/wasm2js.test
@@ -662,6 +662,22 @@
 ;; CHECK-NEXT:
 ;; CHECK-NEXT:   --disable-bulk-memory                         Disable bulk memory operations
 ;; CHECK-NEXT:
+;; CHECK-NEXT:   --enable-bulk-memory-opt                      Enable memory.copy and
+;; CHECK-NEXT:                                                 memory.fill
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --disable-bulk-memory-opt                     Disable memory.copy and
+;; CHECK-NEXT:                                                 memory.fill
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --enable-call-indirect-overlong               Enable LEB encoding of
+;; CHECK-NEXT:                                                 call-indirect (Ignored for
+;; CHECK-NEXT:                                                 compatibility as it has no
+;; CHECK-NEXT:                                                 effect on Binaryen)
+;; CHECK-NEXT:
+;; CHECK-NEXT:   --disable-call-indirect-overlong              Disable LEB encoding of
+;; CHECK-NEXT:                                                 call-indirect (Ignored for
+;; CHECK-NEXT:                                                 compatibility as it has no
+;; CHECK-NEXT:                                                 effect on Binaryen)
+;; CHECK-NEXT:
 ;; CHECK-NEXT:   --enable-exception-handling                   Enable exception handling
 ;; CHECK-NEXT:                                                 operations
 ;; CHECK-NEXT:
diff --git a/test/lld/em_asm_pthread.wasm.out b/test/lld/em_asm_pthread.wasm.out
index 8284cc6dc..aae8441f6 100644
--- a/test/lld/em_asm_pthread.wasm.out
+++ b/test/lld/em_asm_pthread.wasm.out
@@ -12831,5 +12831,5 @@
   )
  )
  ;; custom section "producers", size 172
- ;; features section: threads, mutable-globals, bulk-memory, sign-ext
+ ;; features section: threads, mutable-globals, bulk-memory, sign-ext, bulk-memory-opt
 )
diff --git a/test/passes/strip-target-features_roundtrip_print-features_all-features.txt b/test/passes/strip-target-features_roundtrip_print-features_all-features.txt
index 901f43bc5..e6b611d4a 100644
--- a/test/passes/strip-target-features_roundtrip_print-features_all-features.txt
+++ b/test/passes/strip-target-features_roundtrip_print-features_all-features.txt
@@ -17,6 +17,8 @@
 --enable-typed-continuations
 --enable-shared-everything
 --enable-fp16
+--enable-bulk-memory-opt
+--enable-call-indirect-overlong
 (module
  (type $0 (func (result v128 externref)))
  (func $foo (type $0) (result v128 externref)
diff --git a/test/unit/input/bulkmem_target_feature.wasm b/test/unit/input/bulkmem_target_feature.wasm
index 3c69d2323..7a762820c 100755
--- a/test/unit/input/bulkmem_target_feature.wasm
+++ b/test/unit/input/bulkmem_target_feature.wasm
diff --git a/test/unit/test_features.py b/test/unit/test_features.py
index f5c3fabc5..c115719e7 100644
--- a/test/unit/test_features.py
+++ b/test/unit/test_features.py
@@ -30,6 +30,9 @@ class FeatureValidationTest(utils.BinaryenTestCase):
     def check_bulk_mem(self, module, error):
         self.check_feature(module, error, '--enable-bulk-memory')
 
+    def check_bulk_mem_opt(self, module, error):
+        self.check_feature(module, error, '--enable-bulk-memory-opt')
+
     def check_exception_handling(self, module, error):
         self.check_feature(module, error, '--enable-exception-handling')
 
@@ -135,8 +138,11 @@ class FeatureValidationTest(utils.BinaryenTestCase):
          )
         )
         '''
+        self.check_bulk_mem_opt(module,
+                                'memory.copy operations require bulk memory operations [--enable-bulk-memory-opt]')
+        # Test that enabling bulk-memory also enables bulk-memory-opt
         self.check_bulk_mem(module,
-                            'Bulk memory operations require bulk memory [--enable-bulk-memory]')
+                            'memory.copy operations require bulk memory operations [--enable-bulk-memory-opt]')
 
     def test_bulk_mem_segment(self):
         module = '''
@@ -306,6 +312,23 @@ class FeatureValidationTest(utils.BinaryenTestCase):
         '''
         self.check_typed_continuations(module, 'all used types should be allowed')
 
+    def test_call_indirect_overlong(self):
+        # Check that the call-indirect-overlong enable and disable are ignored.
+        module = '''
+        (module)
+        '''
+
+        def check_nop(flag):
+            p = shared.run_process(
+                shared.WASM_OPT + ['--mvp-features', '--print', '-o', os.devnull] +
+                [flag],
+                input=module,
+                check=False,
+                capture_output=True)
+            self.assertEqual(p.returncode, 0)
+        check_nop('--enable-call-indirect-overlong')
+        check_nop('--disable-call-indirect-overlong')
+
 
 class TargetFeaturesSectionTest(utils.BinaryenTestCase):
     def test_atomics(self):
@@ -314,10 +337,10 @@ class TargetFeaturesSectionTest(utils.BinaryenTestCase):
         self.check_features(filename, ['threads'])
         self.assertIn('i32.atomic.rmw.add', self.disassemble(filename))
 
-    def test_bulk_memory(self):
+    def test_bulk_memory_opt(self):
         filename = 'bulkmem_target_feature.wasm'
         self.roundtrip(filename)
-        self.check_features(filename, ['bulk-memory'])
+        self.check_features(filename, ['bulk-memory-opt'])
         self.assertIn('memory.copy', self.disassemble(filename))
 
     def test_nontrapping_fptoint(self):
@@ -427,4 +450,5 @@ class TargetFeaturesSectionTest(utils.BinaryenTestCase):
             '--enable-typed-continuations',
             '--enable-shared-everything',
             '--enable-fp16',
+            '--enable-bulk-memory-opt',
         ], p2.stdout.splitlines())