diff options
| -rw-r--r-- | src/wasm/wasm-validator.cpp | 2 | ||||
| -rw-r--r-- | test/spec/br_on_null.wast | 16 |
2 files changed, 17 insertions, 1 deletions
diff --git a/src/wasm/wasm-validator.cpp b/src/wasm/wasm-validator.cpp index bbc92f09c..6035a38a9 100644 --- a/src/wasm/wasm-validator.cpp +++ b/src/wasm/wasm-validator.cpp @@ -2252,10 +2252,10 @@ void FunctionValidator::visitBrOn(BrOn* curr) { // casts to. shouldBeTrue( curr->rtt->type.isRtt(), curr, "br_on_cast rtt must have rtt type"); - noteBreak(curr->name, curr->getSentType(), curr); } else { shouldBeTrue(curr->rtt == nullptr, curr, "non-cast BrOn must not have rtt"); } + noteBreak(curr->name, curr->getSentType(), curr); } void FunctionValidator::visitRttCanon(RttCanon* curr) { diff --git a/test/spec/br_on_null.wast b/test/spec/br_on_null.wast index 04b9f41db..8e0a8591f 100644 --- a/test/spec/br_on_null.wast +++ b/test/spec/br_on_null.wast @@ -40,3 +40,19 @@ (func (param $r (ref func)) (drop (br_on_null 0 (local.get $r)))) (func (param $r (ref extern)) (drop (br_on_null 0 (local.get $r)))) ) + +(assert_invalid + ;; the same module as the first one in this file, but with a type added to + ;; the block + (module + (type $t (func (result i32))) + + (func $nn (param $r (ref $t)) (result i32) + (block $l (ref null $t) ;; br_on_null sends no value; a br to here is bad + (return (call_ref (br_on_null $l (local.get $r)))) + ) + (i32.const -1) + ) + ) + "bad break type" +) |