diff options
| -rw-r--r-- | src/passes/RemoveUnusedBrs.cpp | 4 | ||||
| -rw-r--r-- | test/lit/passes/remove-unused-brs-gc.wast | 39 |
2 files changed, 43 insertions, 0 deletions
diff --git a/src/passes/RemoveUnusedBrs.cpp b/src/passes/RemoveUnusedBrs.cpp index 4fda7afb2..a5950f2fa 100644 --- a/src/passes/RemoveUnusedBrs.cpp +++ b/src/passes/RemoveUnusedBrs.cpp @@ -719,6 +719,10 @@ struct RemoveUnusedBrs : public WalkerPass<PostWalker<RemoveUnusedBrs>> { Type refType = Properties::getFallthroughType(curr->ref, passOptions, *getModule()); + if (refType == Type::unreachable) { + // Leave this to DCE. + return; + } assert(refType.isRef()); // When we optimize based on all the fallthrough type information diff --git a/test/lit/passes/remove-unused-brs-gc.wast b/test/lit/passes/remove-unused-brs-gc.wast index 0d0a94cd8..6f7dd5819 100644 --- a/test/lit/passes/remove-unused-brs-gc.wast +++ b/test/lit/passes/remove-unused-brs-gc.wast @@ -595,6 +595,45 @@ ) ) + ;; CHECK: (func $fallthrough-unreachable (type $i31ref_=>_anyref) (param $0 i31ref) (result anyref) + ;; CHECK-NEXT: (block $outer + ;; CHECK-NEXT: (drop + ;; CHECK-NEXT: (block ;; (replaces something unreachable we can't emit) + ;; CHECK-NEXT: (drop + ;; CHECK-NEXT: (block + ;; CHECK-NEXT: (drop + ;; CHECK-NEXT: (ref.cast none + ;; CHECK-NEXT: (local.get $0) + ;; CHECK-NEXT: ) + ;; CHECK-NEXT: ) + ;; CHECK-NEXT: (unreachable) + ;; CHECK-NEXT: ) + ;; CHECK-NEXT: ) + ;; CHECK-NEXT: (unreachable) + ;; CHECK-NEXT: ) + ;; CHECK-NEXT: ) + ;; CHECK-NEXT: (unreachable) + ;; CHECK-NEXT: ) + ;; CHECK-NEXT: ) + (func $fallthrough-unreachable (param $0 i31ref) (result anyref) + (block $outer (result (ref none)) + (drop + ;; This should not crash due to the new unreachable below. + (br_on_cast $outer (ref none) (ref none) + (ref.cast none + ;; This will be optimized to a drop + unreachable. + (br_on_cast $outer (ref none) (ref none) + (ref.cast none + (local.get $0) + ) + ) + ) + ) + ) + (unreachable) + ) + ) + ;; CHECK: (func $casts-are-costly (type $i32_=>_none) (param $x i32) ;; CHECK-NEXT: (local $struct (ref null $struct)) ;; CHECK-NEXT: (drop |