diff options
Diffstat (limited to 'src')
-rw-r--r-- | src/abi/js.h | 36 | ||||
-rw-r--r-- | src/asmjs/shared-constants.cpp | 7 | ||||
-rw-r--r-- | src/emscripten-optimizer/parser.cpp | 4 | ||||
-rw-r--r-- | src/emscripten-optimizer/parser.h | 4 | ||||
-rw-r--r-- | src/passes/I64ToI32Lowering.cpp | 4 | ||||
-rw-r--r-- | src/passes/RemoveNonJSOps.cpp | 2 | ||||
-rw-r--r-- | src/tools/wasm2js.cpp | 2 | ||||
-rw-r--r-- | src/wasm2js.h | 170 |
8 files changed, 175 insertions, 54 deletions
diff --git a/src/abi/js.h b/src/abi/js.h index de74899b6..c8ac94407 100644 --- a/src/abi/js.h +++ b/src/abi/js.h @@ -44,14 +44,21 @@ extern cashew::IString SCRATCH_LOAD_F32; extern cashew::IString SCRATCH_STORE_F32; extern cashew::IString SCRATCH_LOAD_F64; extern cashew::IString SCRATCH_STORE_F64; +extern cashew::IString MEMORY_INIT; +extern cashew::IString MEMORY_FILL; +extern cashew::IString MEMORY_COPY; +extern cashew::IString DATA_DROP; +extern cashew::IString ATOMIC_WAIT_I32; +extern cashew::IString ATOMIC_RMW_I64; +extern cashew::IString GET_STASHED_BITS; -// The wasm2js scratch memory helpers let us read and write to scratch memory -// for purposes of implementing things like reinterpret, etc. +// The wasm2js helpers let us do things that can't be done without special help, +// like read and write to scratch memory for purposes of implementing things +// like reinterpret, etc. // The optional "specific" parameter is a specific function we want. If not // provided, we create them all. -inline void -ensureScratchMemoryHelpers(Module* wasm, - cashew::IString specific = cashew::IString()) { +inline void ensureHelpers(Module* wasm, + cashew::IString specific = cashew::IString()) { auto ensureImport = [&](Name name, Type params, Type results) { if (wasm->getFunctionOrNull(name)) { return; @@ -75,13 +82,28 @@ ensureScratchMemoryHelpers(Module* wasm, ensureImport(SCRATCH_STORE_F32, {Type::f32}, Type::none); ensureImport(SCRATCH_LOAD_F64, {}, Type::f64); ensureImport(SCRATCH_STORE_F64, {Type::f64}, Type::none); + ensureImport( + MEMORY_INIT, {Type::i32, Type::i32, Type::i32, Type::i32}, Type::none); + ensureImport(MEMORY_FILL, {Type::i32, Type::i32, Type::i32}, Type::none); + ensureImport(MEMORY_COPY, {Type::i32, Type::i32, Type::i32}, Type::none); + ensureImport(DATA_DROP, {Type::i32}, Type::none); + ensureImport( + ATOMIC_WAIT_I32, {Type::i32, Type::i32, Type::i32, Type::i32}, Type::i32); + ensureImport( + ATOMIC_RMW_I64, + {Type::i32, Type::i32, Type::i32, Type::i32, Type::i32, Type::i32}, + Type::i32); + ensureImport(GET_STASHED_BITS, {}, Type::i32); } -inline bool isScratchMemoryHelper(cashew::IString name) { +inline bool isHelper(cashew::IString name) { return name == SCRATCH_LOAD_I32 || name == SCRATCH_STORE_I32 || name == SCRATCH_LOAD_I64 || name == SCRATCH_STORE_I64 || name == SCRATCH_LOAD_F32 || name == SCRATCH_STORE_F32 || - name == SCRATCH_LOAD_F64 || name == SCRATCH_STORE_F64; + name == SCRATCH_LOAD_F64 || name == SCRATCH_STORE_F64 || + name == ATOMIC_WAIT_I32 || name == MEMORY_INIT || + name == MEMORY_FILL || name == MEMORY_COPY || name == DATA_DROP || + name == ATOMIC_RMW_I64 || name == GET_STASHED_BITS; } } // namespace wasm2js diff --git a/src/asmjs/shared-constants.cpp b/src/asmjs/shared-constants.cpp index 58742fb1d..8a13cf55c 100644 --- a/src/asmjs/shared-constants.cpp +++ b/src/asmjs/shared-constants.cpp @@ -119,6 +119,13 @@ cashew::IString SCRATCH_LOAD_F32("wasm2js_scratch_load_f32"); cashew::IString SCRATCH_STORE_F32("wasm2js_scratch_store_f32"); cashew::IString SCRATCH_LOAD_F64("wasm2js_scratch_load_f64"); cashew::IString SCRATCH_STORE_F64("wasm2js_scratch_store_f64"); +cashew::IString MEMORY_INIT("wasm2js_memory_init"); +cashew::IString MEMORY_FILL("wasm2js_memory_fill"); +cashew::IString MEMORY_COPY("wasm2js_memory_copy"); +cashew::IString DATA_DROP("wasm2js_data_drop"); +cashew::IString ATOMIC_WAIT_I32("wasm2js_atomic_wait_i32"); +cashew::IString ATOMIC_RMW_I64("wasm2js_atomic_rmw_i64"); +cashew::IString GET_STASHED_BITS("wasm2js_get_stashed_bits"); } // namespace wasm2js } // namespace ABI diff --git a/src/emscripten-optimizer/parser.cpp b/src/emscripten-optimizer/parser.cpp index 72740908e..de749817f 100644 --- a/src/emscripten-optimizer/parser.cpp +++ b/src/emscripten-optimizer/parser.cpp @@ -103,6 +103,10 @@ IString ARRAY("array"); IString OBJECT("object"); IString THROW("throw"); IString SET("="); +IString ATOMICS("Atomics"); +IString COMPARE_EXCHANGE("compareExchange"); +IString LOAD("load"); +IString STORE("store"); IStringSet keywords("var const function if else do while for break continue return " diff --git a/src/emscripten-optimizer/parser.h b/src/emscripten-optimizer/parser.h index 1d4cda79b..3e1623c19 100644 --- a/src/emscripten-optimizer/parser.h +++ b/src/emscripten-optimizer/parser.h @@ -120,6 +120,10 @@ extern IString ARRAY; extern IString OBJECT; extern IString THROW; extern IString SET; +extern IString ATOMICS; +extern IString COMPARE_EXCHANGE; +extern IString LOAD; +extern IString STORE; extern IStringSet keywords; diff --git a/src/passes/I64ToI32Lowering.cpp b/src/passes/I64ToI32Lowering.cpp index 2072f6614..711900e1d 100644 --- a/src/passes/I64ToI32Lowering.cpp +++ b/src/passes/I64ToI32Lowering.cpp @@ -521,7 +521,7 @@ struct I64ToI32Lowering : public WalkerPass<PostWalker<I64ToI32Lowering>> { setOutParam(result, std::move(highBits)); replaceCurrent(result); MemoryUtils::ensureExists(getModule()->memory); - ABI::wasm2js::ensureScratchMemoryHelpers(getModule()); + ABI::wasm2js::ensureHelpers(getModule()); } void lowerReinterpretInt64(Unary* curr) { @@ -539,7 +539,7 @@ struct I64ToI32Lowering : public WalkerPass<PostWalker<I64ToI32Lowering>> { builder->makeCall(ABI::wasm2js::SCRATCH_LOAD_F64, {}, Type::f64)); replaceCurrent(result); MemoryUtils::ensureExists(getModule()->memory); - ABI::wasm2js::ensureScratchMemoryHelpers(getModule()); + ABI::wasm2js::ensureHelpers(getModule()); } void lowerTruncFloatToInt(Unary* curr) { diff --git a/src/passes/RemoveNonJSOps.cpp b/src/passes/RemoveNonJSOps.cpp index 1866877c0..3c1947725 100644 --- a/src/passes/RemoveNonJSOps.cpp +++ b/src/passes/RemoveNonJSOps.cpp @@ -52,7 +52,7 @@ struct RemoveNonJSOpsPass : public WalkerPass<PostWalker<RemoveNonJSOpsPass>> { void doWalkModule(Module* module) { // Intrinsics may use scratch memory, ensure it. - ABI::wasm2js::ensureScratchMemoryHelpers(module); + ABI::wasm2js::ensureHelpers(module); // Discover all of the intrinsics that we need to inject, lowering all // operations to intrinsic calls while we're at it. diff --git a/src/tools/wasm2js.cpp b/src/tools/wasm2js.cpp index b1fc45146..f12d5189d 100644 --- a/src/tools/wasm2js.cpp +++ b/src/tools/wasm2js.cpp @@ -62,7 +62,7 @@ static void optimizeWasm(Module& wasm, PassOptions options) { template<typename T> static void printJS(Ref ast, T& output) { JSPrinter jser(true, true, ast); jser.printAst(); - output << jser.buffer << std::endl; + output << jser.buffer << '\n'; } // Traversals diff --git a/src/wasm2js.h b/src/wasm2js.h index a904bd0f9..fe558c03b 100644 --- a/src/wasm2js.h +++ b/src/wasm2js.h @@ -275,7 +275,7 @@ Ref Wasm2JSBuilder::processWasm(Module* wasm, Name funcName) { // Ensure the scratch memory helpers. // If later on they aren't needed, we'll clean them up. - ABI::wasm2js::ensureScratchMemoryHelpers(wasm); + ABI::wasm2js::ensureHelpers(wasm); // Process the code, and optimize if relevant. // First, do the lowering to a JS-friendly subset. @@ -496,7 +496,7 @@ void Wasm2JSBuilder::addBasics(Ref ast) { void Wasm2JSBuilder::addFunctionImport(Ref ast, Function* import) { // The scratch memory helpers are emitted in the glue, see code and comments // below. - if (ABI::wasm2js::isScratchMemoryHelper(import->base)) { + if (ABI::wasm2js::isHelper(import->base)) { return; } Ref theVar = ValueBuilder::makeVar(); @@ -1404,10 +1404,10 @@ Ref Wasm2JSBuilder::processFunctionBody(Module* m, L_NOT, visit(curr->value, EXPRESSION_RESULT)); } case ReinterpretFloat32: { - ABI::wasm2js::ensureScratchMemoryHelpers( - module, ABI::wasm2js::SCRATCH_STORE_F32); - ABI::wasm2js::ensureScratchMemoryHelpers( - module, ABI::wasm2js::SCRATCH_LOAD_I32); + ABI::wasm2js::ensureHelpers(module, + ABI::wasm2js::SCRATCH_STORE_F32); + ABI::wasm2js::ensureHelpers(module, + ABI::wasm2js::SCRATCH_LOAD_I32); Ref store = ValueBuilder::makeCall(ABI::wasm2js::SCRATCH_STORE_F32, @@ -1482,10 +1482,10 @@ Ref Wasm2JSBuilder::processFunctionBody(Module* m, return makeAsmCoercion(visit(curr->value, EXPRESSION_RESULT), ASM_FLOAT); case ReinterpretInt32: { - ABI::wasm2js::ensureScratchMemoryHelpers( - module, ABI::wasm2js::SCRATCH_STORE_I32); - ABI::wasm2js::ensureScratchMemoryHelpers( - module, ABI::wasm2js::SCRATCH_LOAD_F32); + ABI::wasm2js::ensureHelpers(module, + ABI::wasm2js::SCRATCH_STORE_I32); + ABI::wasm2js::ensureHelpers(module, + ABI::wasm2js::SCRATCH_LOAD_F32); Ref store = ValueBuilder::makeCall(ABI::wasm2js::SCRATCH_STORE_I32, @@ -1839,20 +1839,31 @@ Ref Wasm2JSBuilder::processFunctionBody(Module* m, WASM_UNREACHABLE("unimp"); } Ref visitMemoryInit(MemoryInit* curr) { - unimplemented(curr); - WASM_UNREACHABLE("unimp"); + ABI::wasm2js::ensureHelpers(module, ABI::wasm2js::MEMORY_INIT); + return ValueBuilder::makeCall(ABI::wasm2js::MEMORY_INIT, + ValueBuilder::makeNum(curr->segment), + visit(curr->dest, EXPRESSION_RESULT), + visit(curr->offset, EXPRESSION_RESULT), + visit(curr->size, EXPRESSION_RESULT)); } Ref visitDataDrop(DataDrop* curr) { - unimplemented(curr); - WASM_UNREACHABLE("unimp"); + ABI::wasm2js::ensureHelpers(module, ABI::wasm2js::DATA_DROP); + return ValueBuilder::makeCall(ABI::wasm2js::DATA_DROP, + ValueBuilder::makeNum(curr->segment)); } Ref visitMemoryCopy(MemoryCopy* curr) { - unimplemented(curr); - WASM_UNREACHABLE("unimp"); + ABI::wasm2js::ensureHelpers(module, ABI::wasm2js::MEMORY_COPY); + return ValueBuilder::makeCall(ABI::wasm2js::MEMORY_COPY, + visit(curr->dest, EXPRESSION_RESULT), + visit(curr->source, EXPRESSION_RESULT), + visit(curr->size, EXPRESSION_RESULT)); } Ref visitMemoryFill(MemoryFill* curr) { - unimplemented(curr); - WASM_UNREACHABLE("unimp"); + ABI::wasm2js::ensureHelpers(module, ABI::wasm2js::MEMORY_FILL); + return ValueBuilder::makeCall(ABI::wasm2js::MEMORY_FILL, + visit(curr->dest, EXPRESSION_RESULT), + visit(curr->value, EXPRESSION_RESULT), + visit(curr->size, EXPRESSION_RESULT)); } Ref visitRefNull(RefNull* curr) { unimplemented(curr); @@ -2077,7 +2088,7 @@ private: void emitMemory(std::string buffer, std::string segmentWriter, std::function<std::string(std::string)> accessGlobal); - void emitScratchMemorySupport(); + void emitSpecialSupport(); }; void Wasm2JSGlue::emitPre() { @@ -2087,7 +2098,7 @@ void Wasm2JSGlue::emitPre() { emitPreES6(); } - emitScratchMemorySupport(); + emitSpecialSupport(); } void Wasm2JSGlue::emitPreEmscripten() { @@ -2117,9 +2128,9 @@ void Wasm2JSGlue::emitPreES6() { ModuleUtils::iterImportedGlobals( wasm, [&](Global* import) { noteImport(import->module, import->base); }); ModuleUtils::iterImportedFunctions(wasm, [&](Function* import) { - // The scratch memory helpers are emitted in the glue, see code and comments + // The special helpers are emitted in the glue, see code and comments // below. - if (ABI::wasm2js::isScratchMemoryHelper(import->base)) { + if (ABI::wasm2js::isHelper(import->base)) { return; } noteImport(import->module, import->base); @@ -2202,9 +2213,9 @@ void Wasm2JSGlue::emitPostES6() { out << "abort:function() { throw new Error('abort'); }"; ModuleUtils::iterImportedFunctions(wasm, [&](Function* import) { - // The scratch memory helpers are emitted in the glue, see code and comments + // The special helpers are emitted in the glue, see code and comments // below. - if (ABI::wasm2js::isScratchMemoryHelper(import->base)) { + if (ABI::wasm2js::isHelper(import->base)) { return; } out << "," << asmangle(import->base.str); @@ -2244,11 +2255,23 @@ void Wasm2JSGlue::emitMemory( std::string buffer, std::string segmentWriter, std::function<std::string(std::string)> accessGlobal) { + if (!wasm.memory.exists) { + return; + } + // Create a helper bufferView to access the buffer if we need one. We use it + // for creating memory segments if we have any (we may not if the segments are + // shipped in a side .mem file, for example), and also in bulk memory + // operations. + if (!wasm.memory.segments.empty() || wasm.features.hasBulkMemory()) { + out << "var bufferView = new Uint8Array(" << buffer << ");\n"; + } + // If there are no memory segments, we don't need to emit any support code for + // segment creation. if (wasm.memory.segments.empty()) { return; } - auto expr = + out << R"(for (var base64ReverseLookup = new Uint8Array(123/*'z'+1*/), i = 25; i >= 0; --i) { base64ReverseLookup[48+i] = 52+i; // '0-9' base64ReverseLookup[65+i] = i; // 'A-Z' @@ -2265,9 +2288,16 @@ void Wasm2JSGlue::emitMemory( uint8Array[j++] = base64ReverseLookup[b64.charCodeAt(i)] << 2 | b1 >> 4; if (j < end) uint8Array[j++] = b1 << 4 | b2 >> 2; if (j < end) uint8Array[j++] = b2 << 6 | base64ReverseLookup[b64.charCodeAt(i+3)]; - } - })"; - out << expr << '\n'; + })"; + if (wasm.features.hasBulkMemory()) { + // Passive segments in bulk memory are initialized into new arrays that are + // passed into here, and we need to return them. + out << R"( + return uint8Array;)"; + } + out << R"( + } + )"; auto globalOffset = [&](const Memory::Segment& segment) { if (auto* c = segment.offset->dynCast<Const>()) { @@ -2281,27 +2311,33 @@ void Wasm2JSGlue::emitMemory( Fatal() << "non-constant offsets aren't supported yet\n"; }; - out << "var bufferView = new Uint8Array(" << buffer << ");\n"; - - for (auto& seg : wasm.memory.segments) { - assert(!seg.isPassive && "passive segments not implemented yet"); - out << "base64DecodeToExistingUint8Array(bufferView, " << globalOffset(seg) - << ", \"" << base64Encode(seg.data) << "\");\n"; + for (Index i = 0; i < wasm.memory.segments.size(); i++) { + auto& seg = wasm.memory.segments[i]; + if (!seg.isPassive) { + // Plain active segments are decoded directly into the main memory. + out << "base64DecodeToExistingUint8Array(bufferView, " + << globalOffset(seg) << ", \"" << base64Encode(seg.data) << "\");\n"; + } else { + // Fancy passive segments are decoded into typed arrays on the side, for + // later copying. + out << "memorySegments[" << i + << "] = base64DecodeToExistingUint8Array(new Uint8Array(" + << seg.data.size() << ")" + << ", 0, \"" << base64Encode(seg.data) << "\");\n"; + } } } -void Wasm2JSGlue::emitScratchMemorySupport() { - // The scratch memory helpers are emitted here the glue. We may also want to - // emit them inline at some point. (The reason they are imports is so that - // they appear as "intrinsics" placeholders, and not normal functions that - // the optimizer might want to do something with.) - bool needScratchMemory = false; +void Wasm2JSGlue::emitSpecialSupport() { + // The special support functions are emitted as part of the JS glue, if we + // need them. + bool need = false; ModuleUtils::iterImportedFunctions(wasm, [&](Function* import) { - if (ABI::wasm2js::isScratchMemoryHelper(import->base)) { - needScratchMemory = true; + if (ABI::wasm2js::isHelper(import->base)) { + need = true; } }); - if (!needScratchMemory) { + if (!need) { return; } @@ -2312,6 +2348,15 @@ void Wasm2JSGlue::emitScratchMemorySupport() { var f64ScratchView = new Float64Array(scratchBuffer); )"; + // If we have passive memory segments, or bulk memory operations that operate + // on segment indexes, we need to store those. + bool needMemorySegmentsList = false; + for (auto& seg : wasm.memory.segments) { + if (seg.isPassive) { + needMemorySegmentsList = true; + } + } + ModuleUtils::iterImportedFunctions(wasm, [&](Function* import) { if (import->base == ABI::wasm2js::SCRATCH_STORE_I32) { out << R"( @@ -2363,8 +2408,47 @@ void Wasm2JSGlue::emitScratchMemorySupport() { return f64ScratchView[0]; } )"; + } else if (import->base == ABI::wasm2js::MEMORY_INIT) { + needMemorySegmentsList = true; + out << R"( + function wasm2js_memory_init(segment, dest, offset, size) { + // TODO: traps on invalid things + bufferView.set(memorySegments[segment].subarray(offset, offset + size), dest); + } + )"; + } else if (import->base == ABI::wasm2js::MEMORY_FILL) { + out << R"( + function wasm2js_memory_fill(dest, value, size) { + dest = dest >>> 0; + size = size >>> 0; + if (dest + size > bufferView.length) throw "trap: invalid memory.fill"; + bufferView.fill(value, dest, dest + size); + } + )"; + } else if (import->base == ABI::wasm2js::MEMORY_COPY) { + out << R"( + function wasm2js_memory_copy(dest, source, size) { + // TODO: traps on invalid things + bufferView.copyWithin(dest, source, source + size); + } + )"; + } else if (import->base == ABI::wasm2js::DATA_DROP) { + needMemorySegmentsList = true; + out << R"( + function wasm2js_data_drop(segment) { + // TODO: traps on invalid things + memorySegments[segment] = new Uint8Array(0); + } + )"; } }); + + if (needMemorySegmentsList) { + out << R"( + var memorySegments = {}; + )"; + } + out << '\n'; } |