summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Mackenzie <acm@muc.de>2022-05-28 12:55:32 +0000
committerAlan Mackenzie <acm@muc.de>2022-05-28 12:55:32 +0000
commitf9ee83bfb9f09a32ca8c15385f0cd3ec12ebde8c (patch)
treea343a5a1dbcba985cbfc9ee0602f9d9f4d85740f
parent908e2e09d08c8058f40295096aec9251944875ca (diff)
downloademacs-f9ee83bfb9f09a32ca8c15385f0cd3ec12ebde8c.tar.gz
emacs-f9ee83bfb9f09a32ca8c15385f0cd3ec12ebde8c.tar.bz2
emacs-f9ee83bfb9f09a32ca8c15385f0cd3ec12ebde8c.zip
do_switch_frame: before leaving mini-window, check other (mru) window is live
This fixes bug#55684. There, with a minibuffer-only frame at start up, Emacs tried to switch to this frame, whose selected window was the mini-window. There is no other active window in this frame, so the attempt to swith to another window failed. * src/frame.c (do_switch_frame): On switching to a frame whose selected window is as above, before selecting the most recently used window, check this ostensible window is an actual live window. Otherwise leave the mini-window selected.
-rw-r--r--src/frame.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/src/frame.c b/src/frame.c
index dc8045f41e6..0c278259a79 100644
--- a/src/frame.c
+++ b/src/frame.c
@@ -1568,8 +1568,14 @@ do_switch_frame (Lisp_Object frame, int track, int for_deletion, Lisp_Object nor
to a different window, the most recently used one, unless there is a
valid active minibuffer in the mini-window. */
if (EQ (f->selected_window, f->minibuffer_window)
+ /* The following test might fail if the mini-window contains a
+ non-active minibuffer. */
&& NILP (Fminibufferp (XWINDOW (f->minibuffer_window)->contents, Qt)))
- Fset_frame_selected_window (frame, call1 (Qget_mru_window, frame), Qnil);
+ {
+ Lisp_Object w = call1 (Qget_mru_window, frame);
+ if (WINDOW_LIVE_P (w)) /* W can be nil in minibuffer-only frames. */
+ Fset_frame_selected_window (frame, w, Qnil);
+ }
Fselect_window (f->selected_window, norecord);