summaryrefslogtreecommitdiff
path: root/lisp/cedet/semantic/complete.el
diff options
context:
space:
mode:
authorPaul Eggert <eggert@cs.ucla.edu>2015-09-20 09:40:35 -0700
committerPaul Eggert <eggert@cs.ucla.edu>2015-09-20 09:42:05 -0700
commitab11a1cf27ebe3791df45cccde3c851affd184dd (patch)
tree026e179d182fed09a07cb0a395fe7543feacb958 /lisp/cedet/semantic/complete.el
parent2ad2f8b084111e1479374fa38450de234242afaf (diff)
downloademacs-ab11a1cf27ebe3791df45cccde3c851affd184dd.tar.gz
emacs-ab11a1cf27ebe3791df45cccde3c851affd184dd.tar.bz2
emacs-ab11a1cf27ebe3791df45cccde3c851affd184dd.zip
Use %s to format strings instead of splicing them
If FOO might contain quotes that are part of a file or variable name, the quotes should not be translated when showing FOO’s name in a diagnostic. So, for example, (message (concat (FOO ": bar"))) is not quite right, as it would translate FOO’s quotes. Change it to (message "%s: bar" FOO) instead. * lisp/allout.el (allout-process-exposed): * lisp/calc/calc-ext.el (calc-do-prefix-help): * lisp/calc/calc-store.el (calc-store-into): * lisp/calendar/todo-mode.el (todo-category-completions): * lisp/cedet/semantic/complete.el (semantic-completion-message): * lisp/org/ob-latex.el (convert-pdf): * lisp/org/org-crypt.el (org-crypt-check-auto-save): * lisp/org/ox-latex.el (org-latex-compile): * lisp/org/ox-man.el (org-man-compile): * lisp/org/ox-odt.el (org-odt--export-wrap): * lisp/org/ox-texinfo.el (org-texinfo-compile): * lisp/progmodes/ruby-mode.el (ruby-in-ppss-context-p): * lisp/progmodes/verilog-mode.el (verilog-batch-execute-func) (verilog-signals-combine-bus, verilog-read-defines) (verilog-getopt-file, verilog-expand-dirnames) (verilog-modi-lookup, verilog-modi-modport-lookup-one): * lisp/term/ns-win.el (ns-spi-service-call): Use %s to avoid translating quotes of file names etc. in diagnostics.
Diffstat (limited to 'lisp/cedet/semantic/complete.el')
-rw-r--r--lisp/cedet/semantic/complete.el2
1 files changed, 1 insertions, 1 deletions
diff --git a/lisp/cedet/semantic/complete.el b/lisp/cedet/semantic/complete.el
index d32b2c4f001..9b7882c7acd 100644
--- a/lisp/cedet/semantic/complete.el
+++ b/lisp/cedet/semantic/complete.el
@@ -156,7 +156,7 @@ Presumably if you call this you will insert something new there."
"Display the string FMT formatted with ARGS at the end of the minibuffer."
(if semantic-complete-inline-overlay
(apply 'message fmt args)
- (message (concat (buffer-string) (apply #'format-message fmt args)))))
+ (apply 'message (concat "%s" fmt) (buffer-string) args)))
;;; ------------------------------------------------------------
;;; MINIBUFFER: Option Selection harnesses