summaryrefslogtreecommitdiff
path: root/lisp/emacs-lisp/checkdoc.el
diff options
context:
space:
mode:
authorStefan Monnier <monnier@iro.umontreal.ca>2015-02-18 11:04:15 -0500
committerStefan Monnier <monnier@iro.umontreal.ca>2015-02-18 11:04:15 -0500
commitad6c1be9230ac8ed517a51778b586055edb952c3 (patch)
treeac42432f2893ee64c4fb91c6844afa663baf97da /lisp/emacs-lisp/checkdoc.el
parent81d89d88aef5de720e7fbeecbfb295d6eaf6fd37 (diff)
downloademacs-ad6c1be9230ac8ed517a51778b586055edb952c3.tar.gz
emacs-ad6c1be9230ac8ed517a51778b586055edb952c3.tar.bz2
emacs-ad6c1be9230ac8ed517a51778b586055edb952c3.zip
* lisp/emacs-lisp/checkdoc.el (checkdoc-show-diagnostics): Don't make bogus
assumptions about window ordering.
Diffstat (limited to 'lisp/emacs-lisp/checkdoc.el')
-rw-r--r--lisp/emacs-lisp/checkdoc.el17
1 files changed, 9 insertions, 8 deletions
diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el
index 47b6e5f81de..288e25e6060 100644
--- a/lisp/emacs-lisp/checkdoc.el
+++ b/lisp/emacs-lisp/checkdoc.el
@@ -2619,14 +2619,15 @@ function called to create the messages."
(defun checkdoc-show-diagnostics ()
"Display the checkdoc diagnostic buffer in a temporary window."
(if checkdoc-pending-errors
- (let ((b (get-buffer checkdoc-diagnostic-buffer)))
- (if b (progn (pop-to-buffer b)
- (goto-char (point-max))
- (re-search-backward "\C-l" nil t)
- (beginning-of-line)
- (forward-line 1)
- (recenter 0)))
- (other-window -1)
+ (let* ((b (get-buffer checkdoc-diagnostic-buffer))
+ (win (if b (display-buffer b))))
+ (when win
+ (with-selected-window win
+ (goto-char (point-max))
+ (re-search-backward "\C-l" nil t)
+ (beginning-of-line)
+ (forward-line 1)
+ (recenter 0)))
(setq checkdoc-pending-errors nil)
nil)))