diff options
author | João Távora <joaotavora@gmail.com> | 2023-02-23 13:58:38 +0000 |
---|---|---|
committer | João Távora <joaotavora@gmail.com> | 2023-02-23 13:58:54 +0000 |
commit | e3be0dbf85c729447776d361ba56ada6b92f0149 (patch) | |
tree | 1574dabd3c3f5ecff180e6d54800cee92f8b75fc /lisp/emacs-lisp/faceup.el | |
parent | 5286111ea1fe442d861cd4a940d86db3fd832139 (diff) | |
download | emacs-e3be0dbf85c729447776d361ba56ada6b92f0149.tar.gz emacs-e3be0dbf85c729447776d361ba56ada6b92f0149.tar.bz2 emacs-e3be0dbf85c729447776d361ba56ada6b92f0149.zip |
Eglot: display completion label when safe
Originally reported in
https://github.com/joaotavora/eglot/discussions/1141 by "Mintsoup".
Eglot doesn't always show the LSP :label property of a CompletionItem
in the completion candidates. That is because label is sometimes not
what should be inserted in the buffer in the end, the :insertText
property supercedes it.
But the label is usually more suitable for display nevertheless and if
the LSP CompletionItem contains either a snippet or a textEdit, it's
safe to display the label, since :exit-function will guarantee that a
suitable buffer insertion is performed.
This change reflects that awareness that when a textEdit is available,
it's acceptable to show the label.
* lisp/progmodes/eglot.el (eglot-completion-at-point): Adjust.
Diffstat (limited to 'lisp/emacs-lisp/faceup.el')
0 files changed, 0 insertions, 0 deletions