diff options
author | Glenn Morris <rgm@gnu.org> | 2010-12-02 09:36:45 -0800 |
---|---|---|
committer | Glenn Morris <rgm@gnu.org> | 2010-12-02 09:36:45 -0800 |
commit | 05907bb3aa0e68c594a0a06c5adaa75fe9817fbf (patch) | |
tree | a18453af2d715dc254afaba8b61002f27a0da7f0 /lisp/emacs-lisp | |
parent | bd77c2effa8ad5a557200b932a23244624dc524b (diff) | |
download | emacs-05907bb3aa0e68c594a0a06c5adaa75fe9817fbf.tar.gz emacs-05907bb3aa0e68c594a0a06c5adaa75fe9817fbf.tar.bz2 emacs-05907bb3aa0e68c594a0a06c5adaa75fe9817fbf.zip |
cl-macs `loop' fix for bug#7492.
* lisp/emacs-lisp/cl-macs.el (cl-parse-loop-clause):
Avoid infinite loop over windows.
Diffstat (limited to 'lisp/emacs-lisp')
-rw-r--r-- | lisp/emacs-lisp/cl-macs.el | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el index 76f677c6198..725b98354af 100644 --- a/lisp/emacs-lisp/cl-macs.el +++ b/lisp/emacs-lisp/cl-macs.el @@ -965,16 +965,25 @@ Valid clauses are: ((memq word '(window windows)) (let ((scr (and (memq (car loop-args) '(in of)) (cl-pop2 loop-args))) - (temp (make-symbol "--cl-var--"))) + (temp (make-symbol "--cl-var--")) + (minip (make-symbol "--cl-minip--"))) (push (list var (if scr (list 'frame-selected-window scr) '(selected-window))) loop-for-bindings) + ;; If we started in the minibuffer, we need to + ;; ensure that next-window will bring us back there + ;; at some point. (Bug#7492). + ;; (Consider using walk-windows instead of loop if + ;; you care about such things.) + (push (list minip `(minibufferp (window-buffer ,var))) + loop-for-bindings) (push (list temp nil) loop-for-bindings) (push (list 'prog1 (list 'not (list 'eq var temp)) (list 'or temp (list 'setq temp var))) loop-body) - (push (list var (list 'next-window var)) loop-for-steps))) + (push (list var (list 'next-window var minip)) + loop-for-steps))) (t (let ((handler (and (symbolp word) |