summaryrefslogtreecommitdiff
path: root/lisp/emacs-lisp
diff options
context:
space:
mode:
authorStefan Kangas <stefankangas@gmail.com>2019-11-02 01:30:36 +0100
committerStefan Kangas <stefankangas@gmail.com>2019-11-02 01:30:36 +0100
commit6297eb0fca9967649bcde6fd160bb6b5d3ce6878 (patch)
treef56ac7d579af006d21542fa833ce348f380d376c /lisp/emacs-lisp
parent2f42832895942fdeaa0c500511aa19860fa806cd (diff)
downloademacs-6297eb0fca9967649bcde6fd160bb6b5d3ce6878.tar.gz
emacs-6297eb0fca9967649bcde6fd160bb6b5d3ce6878.tar.bz2
emacs-6297eb0fca9967649bcde6fd160bb6b5d3ce6878.zip
Don't refuse to install packages without a "footer line"
* lisp/emacs-lisp/package.el (package-buffer-info): Don't signal an error when the "footer line" is missing. Warn only. (Bug#26490) * etc/NEWS: Announce it.
Diffstat (limited to 'lisp/emacs-lisp')
-rw-r--r--lisp/emacs-lisp/package.el9
1 files changed, 6 insertions, 3 deletions
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 645e831bcc9..8c8e86aead9 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -1082,10 +1082,13 @@ boundaries."
(let ((file-name (match-string-no-properties 1))
(desc (match-string-no-properties 2))
(start (line-beginning-position)))
- ;; The terminating comment format could be extended to accept a
- ;; generic string that is not in English.
+ ;; This warning was added in Emacs 27.1, and should be removed at
+ ;; the earliest in version 31.1. The idea is to phase out the
+ ;; requirement for a "footer line" without unduly impacting users
+ ;; on earlier Emacs versions. See Bug#26490 for more details.
(unless (search-forward (concat ";;; " file-name ".el ends here"))
- (error "Package lacks a terminating comment"))
+ (lwarn '(package package-format) :warning
+ "Package lacks a terminating comment"))
;; Try to include a trailing newline.
(forward-line)
(narrow-to-region start (point))