diff options
author | Stefan Monnier <monnier@iro.umontreal.ca> | 2012-07-11 19:13:41 -0400 |
---|---|---|
committer | Stefan Monnier <monnier@iro.umontreal.ca> | 2012-07-11 19:13:41 -0400 |
commit | a464a6c73acf27b0d633d428919a36bc16a9d442 (patch) | |
tree | bcba70ce0242bfd5987356c750ba4eb6b58820b1 /lisp/play/pong.el | |
parent | c214e35e489145bd3a8ab7a353671f947368a7ae (diff) | |
download | emacs-a464a6c73acf27b0d633d428919a36bc16a9d442.tar.gz emacs-a464a6c73acf27b0d633d428919a36bc16a9d442.tar.bz2 emacs-a464a6c73acf27b0d633d428919a36bc16a9d442.zip |
More CL cleanups and reduction of use of cl.el.
* woman.el, winner.el, vc/vc-rcs.el, vc/vc-hooks.el, vc/vc-hg.el:
* vc/vc-git.el, vc/vc-dir.el, vc/vc-bzr.el, vc/vc-annotate.el:
* textmodes/tex-mode.el, textmodes/sgml-mode.el, tar-mode.el:
* strokes.el, ses.el, server.el, progmodes/js.el, progmodes/gdb-mi.el:
* progmodes/flymake.el, progmodes/ebrowse.el, progmodes/compile.el:
* play/tetris.el, play/snake.el, play/pong.el, play/landmark.el:
* play/hanoi.el, play/decipher.el, play/5x5.el, nxml/nxml-mode.el:
* net/secrets.el, net/quickurl.el, midnight.el, mail/footnote.el:
* image-dired.el, ibuffer.el, ibuf-macs.el, ibuf-ext.el, hexl.el:
* eshell/eshell.el, eshell/esh-io.el, eshell/esh-ext.el:
* eshell/esh-cmd.el, eshell/em-ls.el, eshell/em-hist.el:
* eshell/em-cmpl.el, eshell/em-banner.el:
* url/url.el, url/url-queue.el, url/url-parse.el, url/url-http.el:
* url/url-future.el, url/url-dav.el, url/url-cookie.el:
* calendar/parse-time.el, test/eshell.el: Use cl-lib.
* wid-browse.el, wdired.el, vc/vc.el, vc/vc-mtn.el, vc/vc-cvs.el:
* vc/vc-arch.el, tree-widget.el, textmodes/texinfo.el:
* textmodes/refill.el, textmodes/css-mode.el, term/tvi970.el:
* term/ns-win.el, term.el, shell.el, ps-samp.el:
* progmodes/perl-mode.el, progmodes/pascal.el, progmodes/gud.el:
* progmodes/glasses.el, progmodes/etags.el, progmodes/cwarn.el:
* play/gamegrid.el, play/bubbles.el, novice.el, notifications.el:
* net/zeroconf.el, net/xesam.el, net/snmp-mode.el, net/mairix.el:
* net/ldap.el, net/eudc.el, net/browse-url.el, man.el:
* mail/mailheader.el, mail/feedmail.el:
* url/url-util.el, url/url-privacy.el, url/url-nfs.el, url/url-misc.el:
* url/url-methods.el, url/url-gw.el, url/url-file.el, url/url-expand.el:
Dont use CL.
* ibuf-ext.el (ibuffer-mark-old-buffers): Use float-time.
* eshell/esh-opt.el (eshell-eval-using-options): Quote code with
`lambda' rather than with `quote'.
(eshell-do-opt): Adjust accordingly.
(eshell-process-option): Simplify.
* eshell/esh-var.el:
* eshell/em-script.el: Require `esh-opt' for eshell-eval-using-options.
* emacs-pcase.el (pcase--dontcare-upats, pcase--let*)
(pcase--expand, pcase--u1): Rename pcase's internal `dontcare' pattern
to `pcase--dontcare'.
* emacs-cl.el (labels): Mark obsolete.
(cl--letf, letf): Move to cl-lib.
(cl--letf*, letf*): Remove.
* emacs-cl-lib.el (cl-nth-value): Use defalias.
* emacs-cl-macs.el (cl-dolist, cl-dotimes): Add indent rule.
(cl-progv): Rewrite.
(cl--letf, cl-letf): Move from cl.el.
(cl-letf*): New macro.
* emacs-cl-extra.el (cl--progv-before, cl--progv-after): Remove.
Diffstat (limited to 'lisp/play/pong.el')
-rw-r--r-- | lisp/play/pong.el | 50 |
1 files changed, 25 insertions, 25 deletions
diff --git a/lisp/play/pong.el b/lisp/play/pong.el index 5742a5c7849..cb165cdf31e 100644 --- a/lisp/play/pong.el +++ b/lisp/play/pong.el @@ -26,7 +26,7 @@ ;;; Code: -(eval-when-compile (require 'cl)) +(eval-when-compile (require 'cl-lib)) (require 'gamegrid) @@ -214,18 +214,18 @@ (defun pong-display-options () "Computes display options (required by gamegrid for colors)." (let ((options (make-vector 256 nil))) - (loop for c from 0 to 255 do + (dotimes (c 256) (aset options c - (cond ((= c pong-blank) - pong-blank-options) + (cond ((= c pong-blank) + pong-blank-options) ((= c pong-bat) - pong-bat-options) + pong-bat-options) ((= c pong-ball) - pong-ball-options) + pong-ball-options) ((= c pong-border) - pong-border-options) + pong-border-options) (t - '(nil nil nil))))) + '(nil nil nil))))) options)) @@ -246,18 +246,19 @@ ?\s) (let ((buffer-read-only nil)) - (loop for y from 0 to (1- pong-height) do - (loop for x from 0 to (1- pong-width) do - (gamegrid-set-cell x y pong-border))) - (loop for y from 1 to (- pong-height 2) do - (loop for x from 1 to (- pong-width 2) do - (gamegrid-set-cell x y pong-blank)))) - - (loop for y from pong-bat-player1 to (1- (+ pong-bat-player1 pong-bat-width)) do - (gamegrid-set-cell 2 y pong-bat)) - (loop for y from pong-bat-player2 to (1- (+ pong-bat-player2 pong-bat-width)) do - (gamegrid-set-cell (- pong-width 3) y pong-bat))) + (dotimes (y pong-height) + (dotimes (x pong-width) + (gamegrid-set-cell x y pong-border))) + (cl-loop for y from 1 to (- pong-height 2) do + (cl-loop for x from 1 to (- pong-width 2) do + (gamegrid-set-cell x y pong-blank)))) + (cl-loop for y from pong-bat-player1 + to (1- (+ pong-bat-player1 pong-bat-width)) + do (gamegrid-set-cell 2 y pong-bat)) + (cl-loop for y from pong-bat-player2 + to (1- (+ pong-bat-player2 pong-bat-width)) + do (gamegrid-set-cell (- pong-width 3) y pong-bat))) (defun pong-move-left () @@ -401,13 +402,12 @@ detection and checks if a player scores." (defun pong-update-score () "Update score and print it on bottom of the game grid." - (let* ((string (format "Score: %d / %d" pong-score-player1 pong-score-player2)) + (let* ((string (format "Score: %d / %d" + pong-score-player1 pong-score-player2)) (len (length string))) - (loop for x from 0 to (1- len) do - (if (string-equal (buffer-name (current-buffer)) pong-buffer-name) - (gamegrid-set-cell x - pong-height - (aref string x)))))) + (dotimes (x len) + (if (string-equal (buffer-name (current-buffer)) pong-buffer-name) + (gamegrid-set-cell x pong-height (aref string x)))))) |