diff options
| author | Jared Finder <jared@finder.org> | 2020-10-11 20:16:00 -0700 |
|---|---|---|
| committer | Eli Zaretskii <eliz@gnu.org> | 2020-10-24 13:26:56 +0300 |
| commit | 2c487c47c8c3060818b2fcbfebbcd859f9d06ef5 (patch) | |
| tree | 0d72868c70492411ee43d8fc786b9e52192ffc6e /lisp | |
| parent | 92d37029a755e7f610c3bc10c816763c5d853d2f (diff) | |
| download | emacs-2c487c47c8c3060818b2fcbfebbcd859f9d06ef5.tar.gz emacs-2c487c47c8c3060818b2fcbfebbcd859f9d06ef5.tar.bz2 emacs-2c487c47c8c3060818b2fcbfebbcd859f9d06ef5.zip | |
Fix a bug where the wrong menu would be triggered by mouse
For layouts such as the following, clicking the "l" in Tools with the
right window focused would trigger the File menu, not the Tools menu.
This is because the event would have window coordinate (1 . 0).
Similarly, clicking the "p" in Help would trigger the Edit menu.
Example Emacs frame:
+--------------------------------------------------------+
|File Edit Options Buffers Tools Help |
|;; This buffer is for text$|;; This buffer is for text $|
|;; To create a file, visit$|;; To create a file, visit $|
| | |
| | |
|-UUU:----F1 *scratch* |-UUU:----F1 *scratch* |
| |
+--------------------------------------------------------+
* lisp/menu-bar.el (menu-bar-open-mouse): Reject clicks not on
the menu bar.
*lisp/xt-mouse.el (xterm-mouse-event): Pass the current frame to
'posn-at-x-y', to make the effect consistent with other mouse-handling
features.
Diffstat (limited to 'lisp')
| -rw-r--r-- | lisp/menu-bar.el | 6 | ||||
| -rw-r--r-- | lisp/xt-mouse.el | 2 |
2 files changed, 7 insertions, 1 deletions
diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el index e42602364d2..f9afc8a5f31 100644 --- a/lisp/menu-bar.el +++ b/lisp/menu-bar.el @@ -2672,6 +2672,12 @@ EVENT should be a mouse down or click event. Also see `menu-bar-open', which this calls. This command is to be used when you click the mouse in the menubar." (interactive "e") + ;; This only should be bound to clicks on the menu-bar, outside of + ;; any window. + (let ((window (posn-window (event-start event)))) + (when window + (error "Event is inside window %s" window))) + (let* ((x-position (car (posn-x-y (event-start event)))) (menu-bar-item-cons (menu-bar-item-at-x x-position))) (menu-bar-open nil diff --git a/lisp/xt-mouse.el b/lisp/xt-mouse.el index 3c0dfb65ecf..f9c08f9a174 100644 --- a/lisp/xt-mouse.el +++ b/lisp/xt-mouse.el @@ -267,7 +267,7 @@ which is the \"1006\" extension implemented in Xterm >= 277." (eq y 1))) 'tab-bar 'menu-bar)) - (nthcdr 2 (posn-at-x-y x y))))) + (nthcdr 2 (posn-at-x-y x y (selected-frame)))))) (event (list type posn))) (setcar (nthcdr 3 posn) timestamp) |