diff options
| author | Yuan Fu <casouri@gmail.com> | 2023-01-08 19:05:19 -0800 |
|---|---|---|
| committer | Yuan Fu <casouri@gmail.com> | 2023-01-08 21:22:06 -0800 |
| commit | ef87c75566018b546e56f64f66f665ebfd8da305 (patch) | |
| tree | 97626b79212932d503077e5d7c9d73c3d0b6ec1e /lisp | |
| parent | 1238fa8e49bdb12db66d856dcb4b192db5d026ff (diff) | |
| download | emacs-ef87c75566018b546e56f64f66f665ebfd8da305.tar.gz emacs-ef87c75566018b546e56f64f66f665ebfd8da305.tar.bz2 emacs-ef87c75566018b546e56f64f66f665ebfd8da305.zip | |
Make sure NODE is not the root node in tree-sitter indent (bug#60602)
There are two possible ways to solve the problem raised in the bug
report: either make sure NODE is never the root (so that parent is
never nil), or allow parent to be nil.
If we go with the latter, a lot of matcher and anchor functions need
change (they need to guard against a null parent). I tried it, and
needing to check for null parent is pretty annoying. In comparison,
if NODE is never the root, it is very convenient for the user, and it
doesn't complicate the rule that much (and it's rather intuitive,
people usually don't think of the case where NODE is the root node).
So that's what I choose.
* doc/lispref/modes.texi (Parser-based Indentation): Update manual.
* lisp/treesit.el (treesit-indent-function): Update docstring.
(treesit--indent-1): Make sure NODE is not the root.
Diffstat (limited to 'lisp')
| -rw-r--r-- | lisp/treesit.el | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/lisp/treesit.el b/lisp/treesit.el index 7205e43916d..e53d5d53bd0 100644 --- a/lisp/treesit.el +++ b/lisp/treesit.el @@ -1341,10 +1341,10 @@ and returns (ANCHOR . OFFSET). BOL is the position of the beginning of the line; NODE is the -\"largest\" node that starts at BOL; PARENT is its parent; ANCHOR -is a point (not a node), and OFFSET is a number. Emacs finds the -column of ANCHOR and adds OFFSET to it as the final indentation -of the current line.") +\"largest\" node that starts at BOL (and isn't a root node); +PARENT is its parent; ANCHOR is a point (not a node), and OFFSET +is a number. Emacs finds the column of ANCHOR and adds OFFSET to +it as the final indentation of the current line.") (defun treesit--indent-1 () "Indent the current line. @@ -1362,10 +1362,13 @@ Return (ANCHOR . OFFSET). This function is used by ((treesit-language-at (point)) (treesit-node-at bol (treesit-language-at (point)))) (t (treesit-node-at bol)))) + (root (treesit-parser-root-node + (treesit-node-parser smallest-node))) (node (treesit-parent-while smallest-node (lambda (node) - (eq bol (treesit-node-start node)))))) + (and (eq bol (treesit-node-start node)) + (not (treesit-node-eq node root))))))) (let* ((parser (if smallest-node (treesit-node-parser smallest-node) |