summaryrefslogtreecommitdiff
path: root/src/ftcrfont.c
diff options
context:
space:
mode:
authorEli Zaretskii <eliz@gnu.org>2020-11-07 10:27:15 +0200
committerEli Zaretskii <eliz@gnu.org>2020-11-07 10:27:15 +0200
commit33e2418a7cfd2ac1b98b86c5ddaf99c1d90daaf0 (patch)
treead299ea59b416e960052af067807240fc8cb406f /src/ftcrfont.c
parentece1e1da5ea86fb02230e10111ea188ee0a59fc9 (diff)
downloademacs-33e2418a7cfd2ac1b98b86c5ddaf99c1d90daaf0.tar.gz
emacs-33e2418a7cfd2ac1b98b86c5ddaf99c1d90daaf0.tar.bz2
emacs-33e2418a7cfd2ac1b98b86c5ddaf99c1d90daaf0.zip
Fix scrolling problems with misc-fixed fonts under Cairo
* src/ftcrfont.c (ftcrfont_glyph_extents): Avoid rounding up the glyph ascent to a higher value than needed due to floating-point roundoff errors. (Bug#44284)
Diffstat (limited to 'src/ftcrfont.c')
-rw-r--r--src/ftcrfont.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/src/ftcrfont.c b/src/ftcrfont.c
index a10308c62ee..b89510704e1 100644
--- a/src/ftcrfont.c
+++ b/src/ftcrfont.c
@@ -84,7 +84,12 @@ ftcrfont_glyph_extents (struct font *font,
cache->lbearing = floor (extents.x_bearing);
cache->rbearing = ceil (extents.width + extents.x_bearing);
cache->width = lround (extents.x_advance);
- cache->ascent = ceil (- extents.y_bearing);
+ /* The subtraction of a small number is to avoid rounding up due
+ to floating-point inaccuracies with some fonts, which then
+ could cause unpleasant effects while scrolling (see bug
+ #44284), since we then think that a glyph row's ascent is too
+ small to accommodate a glyph with a higher phys_ascent. */
+ cache->ascent = ceil (- extents.y_bearing - 1.0 / 256);
cache->descent = ceil (extents.height + extents.y_bearing);
}