diff options
author | Paul Eggert <eggert@cs.ucla.edu> | 2011-07-28 16:58:05 -0700 |
---|---|---|
committer | Paul Eggert <eggert@cs.ucla.edu> | 2011-07-28 16:58:05 -0700 |
commit | 0eb0f3187d46ec0efdfc1df38565c160c759ecb2 (patch) | |
tree | 2f87e3fc4534e20652a07cd897d3e55c5819c247 /src/gtkutil.h | |
parent | 1ffd9c92ea38e078ec6cde6277c7ce88895212df (diff) | |
download | emacs-0eb0f3187d46ec0efdfc1df38565c160c759ecb2.tar.gz emacs-0eb0f3187d46ec0efdfc1df38565c160c759ecb2.tar.bz2 emacs-0eb0f3187d46ec0efdfc1df38565c160c759ecb2.zip |
* gtkutil.c: Integer overflow fixes.
(get_utf8_string, xg_store_widget_in_map):
Check for size-calculation overflow.
(get_utf8_string): Use ptrdiff_t, not size_t, where either will
do, as we prefer signed integers.
(id_to_widget.max_size, id_to_widget.used)
(xg_store_widget_in_map, xg_remove_widget_from_map)
(xg_get_widget_from_map, xg_get_scroll_id_for_window)
(xg_remove_scroll_bar, xg_update_scrollbar_pos):
Use and return ptrdiff_t, not int.
(xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
* gtkutil.h: Change prototypes to match the above.
Diffstat (limited to 'src/gtkutil.h')
-rw-r--r-- | src/gtkutil.h | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/gtkutil.h b/src/gtkutil.h index 769e56da917..2dfb3a5ed6c 100644 --- a/src/gtkutil.h +++ b/src/gtkutil.h @@ -114,17 +114,17 @@ extern int xg_event_is_for_menubar (FRAME_PTR f, XEvent *event); extern int xg_have_tear_offs (void); -extern int xg_get_scroll_id_for_window (Display *dpy, Window wid); +extern ptrdiff_t xg_get_scroll_id_for_window (Display *dpy, Window wid); extern void xg_create_scroll_bar (FRAME_PTR f, struct scroll_bar *bar, GCallback scroll_callback, GCallback end_callback, const char *scroll_bar_name); -extern void xg_remove_scroll_bar (FRAME_PTR f, int scrollbar_id); +extern void xg_remove_scroll_bar (FRAME_PTR f, ptrdiff_t scrollbar_id); extern void xg_update_scrollbar_pos (FRAME_PTR f, - int scrollbar_id, + ptrdiff_t scrollbar_id, int top, int left, int width, @@ -185,4 +185,3 @@ extern int xg_ignore_gtk_scrollbar; #endif /* USE_GTK */ #endif /* GTKUTIL_H */ - |