summaryrefslogtreecommitdiff
path: root/src/pgtkselect.c
diff options
context:
space:
mode:
authorPo Lu <luangruo@yahoo.com>2022-04-06 12:27:57 +0800
committerPo Lu <luangruo@yahoo.com>2022-04-06 12:27:57 +0800
commit62eb57f43871dacb6c7ac1f6e2cdaf7add1414e2 (patch)
tree0f4257717da2612a0780240058f7fdff97f92af0 /src/pgtkselect.c
parentf0ff20be51980731364ef5ccf0505c35ea1b4e78 (diff)
downloademacs-62eb57f43871dacb6c7ac1f6e2cdaf7add1414e2.tar.gz
emacs-62eb57f43871dacb6c7ac1f6e2cdaf7add1414e2.tar.bz2
emacs-62eb57f43871dacb6c7ac1f6e2cdaf7add1414e2.zip
Clean up more PGTK code
* lisp/term/pgtk-win.el (featurep): (pgtk): (pgtk-use-im-context): (pgtk-handle-nxopen): (pgtk-handle-nxopentemp): (pgtk-ignore-1-arg): ([C-drag-n-drop]): ([M-drag-n-drop]): ([C-M-drag-n-drop]): (pgtk-alternate-modifier): (pgtk-right-alternate-modifier): (pgtk-right-command-modifier): (pgtk-right-control-modifier): (pgtk-do-hide-emacs): (pgtk-hide-others): (pgtk-do-hide-others): (pgtk-emacs-info-panel): (pgtk-do-emacs-info-panel): (pgtk-next-frame): (pgtk-prev-frame): (after-make-frame-functions): (tool-bar-mode): (pgtk-toggle-toolbar): (pgtk-print-buffer): (scalable-fonts-allowed): (pgtk-standard-fontset-spec): (pgtk-store-cut-buffer-internal): (pgtk-copy-including-secondary): (pgtk-paste-secondary): (pgtk-suspend-error): (window-system-initialization): (after-init-hook): Remove code mindlessly copied from ns-win.el, delete unused custom group, write doc strings and rename variables duplicated from X to their names on X. Also reformat comments and code. (pgtk-use-im-context-handler): New function. * src/pgtkfns.c (syms_of_pgtkfns): Delete useless AppleScript (!) code copied from NS. * src/pgtkselect.c: Write FIXME about selection API usage. * src/pgtkterm.c (get_keysym_name): Implement correctly instead of sprintf'ing the numeric value of the keysym into a static buffer. (pgtk_set_window_size): (xg_scroll_callback): Delete code that was #if 0'd out and doesn't make sense on PGTK. (pgtk_delete_terminal): Remove misleading comment.
Diffstat (limited to 'src/pgtkselect.c')
-rw-r--r--src/pgtkselect.c22
1 files changed, 11 insertions, 11 deletions
diff --git a/src/pgtkselect.c b/src/pgtkselect.c
index 2660ea3ed38..2f4a872a05b 100644
--- a/src/pgtkselect.c
+++ b/src/pgtkselect.c
@@ -17,13 +17,15 @@ GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>. */
-/*
-Originally by Carl Edman
-Updated by Christian Limpach (chris@nice.ch)
-OpenStep/Rhapsody port by Scott Bender (sbender@harmony-ds.com)
-macOS/Aqua port by Christophe de Dinechin (descubes@earthlink.net)
-GNUstep port and post-20 update by Adrian Robert (arobert@cogsci.ucsd.edu)
-*/
+/* FIXME: this file needs a major rewrite to replace the use of GTK's
+ own high-level GtkClipboard API with the GDK selection API:
+
+ https://developer-old.gnome.org/gdk3/stable/gdk3-Selections.html
+
+ That way, most of the code can be shared with X, and non-text
+ targets along with drag-and-drop can be supported. GDK implements
+ selections according to the ICCCM, as on X, but its selection API
+ will work on any supported window system. */
/* This should be the first include, as it may set up #defines affecting
interpretation of even the system includes. */
@@ -151,10 +153,8 @@ selection_type_to_quarks (GdkAtom type, GQuark * quark_data,
*quark_size = quark_clipboard_size;
}
else
- {
- /* fixme: Is it safe to use 'error' here? */
- error ("Unknown selection type.");
- }
+ /* FIXME: Is it safe to use 'error' here? */
+ error ("Unknown selection type.");
}
static void