summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorEli Zaretskii <eliz@gnu.org>2016-12-23 16:17:52 +0200
committerEli Zaretskii <eliz@gnu.org>2016-12-23 16:17:52 +0200
commiteff901b8a39f42ddedf4c1db833b9071cae5962f (patch)
tree0dcb20eeeb10b6399ba125f73a6677f38a02e68a /src
parent6eaadcc7c821b7a8c75ce6d1d56cd7f50898f809 (diff)
downloademacs-eff901b8a39f42ddedf4c1db833b9071cae5962f.tar.gz
emacs-eff901b8a39f42ddedf4c1db833b9071cae5962f.tar.bz2
emacs-eff901b8a39f42ddedf4c1db833b9071cae5962f.zip
Prevent infloops in redisplay due to truncate-lines and overlays
* src/xdisp.c (hscroll_window_tree): Avoid inflooping in redisplay_window when a screen line ends in an overlay string with a newline. (Bug#25246)
Diffstat (limited to 'src')
-rw-r--r--src/xdisp.c11
1 files changed, 11 insertions, 0 deletions
diff --git a/src/xdisp.c b/src/xdisp.c
index ad0b9686f04..5de5ecaef0d 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -13049,6 +13049,17 @@ hscroll_window_tree (Lisp_Object window)
init_to_row_start (&it, w, cursor_row);
it.last_visible_x = INFINITY;
move_it_in_display_line_to (&it, pt, -1, MOVE_TO_POS);
+ /* If the line ends in an overlay string with a newline,
+ we might infloop, because displaying the window will
+ want to put the cursor after the overlay, i.e. at X
+ coordinate of zero on the next screen line. So we
+ use the buffer position prior to the overlay string
+ instead. */
+ if (it.method == GET_FROM_STRING && pt > 1)
+ {
+ init_to_row_start (&it, w, cursor_row);
+ move_it_in_display_line_to (&it, pt - 1, -1, MOVE_TO_POS);
+ }
current_buffer = saved_current_buffer;
/* Position cursor in window. */