diff options
| author | F. Jason Park <jp@neverwas.me> | 2022-11-24 21:03:03 -0800 |
|---|---|---|
| committer | F. Jason Park <jp@neverwas.me> | 2022-11-25 05:37:01 -0800 |
| commit | 3d02c8aabfde88219dd8b6053a59de261308bc2f (patch) | |
| tree | 7720ff6524d15f2231319bbacc3f6bf9362b0e52 /test/lisp/auth-source-pass-tests.el | |
| parent | 94a8a8c4fef074f445d316000070c95f0452586e (diff) | |
| download | emacs-3d02c8aabfde88219dd8b6053a59de261308bc2f.tar.gz emacs-3d02c8aabfde88219dd8b6053a59de261308bc2f.tar.bz2 emacs-3d02c8aabfde88219dd8b6053a59de261308bc2f.zip | |
Disable auth-source-pass-extra-query-keywords by default
* doc/misc/auth.texi: Mention subdomain matching in
`auth-source-pass-extra-query-keywords' section.
* etc/NEWS: Mention the loss of traditional auth-source-pass features
when `auth-source-pass-extra-query-keywords' is enabled.
* lisp/auth-source-pass (auth-source-pass-extra-query-keywords): Set
default to nil. Mention domain matching in doc string.
(auth-source-pass--match-regexp): Allow username to contain "@".
* lisp/erc/erc-compat.el:
(erc-compat--29-auth-source-pass--retrieve-parsed): Adjust regexp.
* test/lisp/auth-source-pass-tests.el
(auth-source-pass-extra-query-keywords--suffixed-user): make plain
username more email-like.
(Bug#58985.)
Diffstat (limited to 'test/lisp/auth-source-pass-tests.el')
| -rw-r--r-- | test/lisp/auth-source-pass-tests.el | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/test/lisp/auth-source-pass-tests.el b/test/lisp/auth-source-pass-tests.el index 6e6671efca5..1107e09b51b 100644 --- a/test/lisp/auth-source-pass-tests.el +++ b/test/lisp/auth-source-pass-tests.el @@ -697,29 +697,29 @@ machine Libera.Chat password b ;; with slightly more realistic and less legible values. (ert-deftest auth-source-pass-extra-query-keywords--suffixed-user () - (let ((store (sort (copy-sequence '(("x.com:42/bar" (secret . "a")) - ("bar@x.com" (secret . "b")) + (let ((store (sort (copy-sequence '(("x.com:42/b@r" (secret . "a")) + ("b@r@x.com" (secret . "b")) ("x.com" (secret . "?")) - ("bar@y.org" (secret . "c")) + ("b@r@y.org" (secret . "c")) ("fake.com" (secret . "?")) - ("fake.com/bar" (secret . "d")) - ("y.org/bar" (secret . "?")) - ("bar@fake.com" (secret . "e")))) + ("fake.com/b@r" (secret . "d")) + ("y.org/b@r" (secret . "?")) + ("b@r@fake.com" (secret . "e")))) (lambda (&rest _) (zerop (random 2)))))) (auth-source-pass--with-store store (auth-source-pass-enable) (let* ((auth-source-pass-extra-query-keywords t) (results (auth-source-search :host '("x.com" "fake.com" "y.org") - :user "bar" + :user "b@r" :require '(:user) :max 5))) (dolist (result results) (setf (plist-get result :secret) (auth-info-password result))) (should (equal results - '((:host "x.com" :user "bar" :secret "b") - (:host "x.com" :user "bar" :port "42" :secret "a") - (:host "fake.com" :user "bar" :secret "e") - (:host "fake.com" :user "bar" :secret "d") - (:host "y.org" :user "bar" :secret "c")))))))) + '((:host "x.com" :user "b@r" :secret "b") + (:host "x.com" :user "b@r" :port "42" :secret "a") + (:host "fake.com" :user "b@r" :secret "e") + (:host "fake.com" :user "b@r" :secret "d") + (:host "y.org" :user "b@r" :secret "c")))))))) ;; This is a more distilled version of `suffixed-user', above. It ;; better illustrates that search order takes precedence over "/user" |