summaryrefslogtreecommitdiff
path: root/test/lisp/emacs-lisp/seq-tests.el
diff options
context:
space:
mode:
authorLars Ingebrigtsen <larsi@gnus.org>2021-12-05 04:20:55 +0100
committerLars Ingebrigtsen <larsi@gnus.org>2021-12-05 04:20:55 +0100
commit8bdea767208257599f6ab727e51dd94f0c1872e1 (patch)
tree2f1e3e0611f13f85daab58fd0780d7d4136b5380 /test/lisp/emacs-lisp/seq-tests.el
parent7842a606b76dfabd1540da1c130728064e8f02ed (diff)
downloademacs-8bdea767208257599f6ab727e51dd94f0c1872e1.tar.gz
emacs-8bdea767208257599f6ab727e51dd94f0c1872e1.tar.bz2
emacs-8bdea767208257599f6ab727e51dd94f0c1872e1.zip
Remove hack from seq-tests.el for broken `with-suppressed-warnings'
* test/lisp/emacs-lisp/seq-tests.el: `with-suppressed-warnings' now works better in erf-deftests, so remove hack that works around it (bug#36568).
Diffstat (limited to 'test/lisp/emacs-lisp/seq-tests.el')
-rw-r--r--test/lisp/emacs-lisp/seq-tests.el24
1 files changed, 10 insertions, 14 deletions
diff --git a/test/lisp/emacs-lisp/seq-tests.el b/test/lisp/emacs-lisp/seq-tests.el
index 8cfa3bdb862..4b940af81f1 100644
--- a/test/lisp/emacs-lisp/seq-tests.el
+++ b/test/lisp/emacs-lisp/seq-tests.el
@@ -172,23 +172,19 @@ Evaluate BODY for each created sequence.
(should-not (seq-find #'null '(1 2 3)))
(should (seq-find #'null '(1 2 3) 'sentinel)))
-;; Hack to work around the ERT limitation that we can't reliably use
-;; `with-suppressed-warnings' inside an `ert-deftest'. (Bug#36568)
-(defun seq--contains (&rest args)
- (with-suppressed-warnings ((obsolete seq-contains))
- (apply #'seq-contains args)))
-
(ert-deftest test-seq-contains ()
- (with-test-sequences (seq '(3 4 5 6))
- (should (seq--contains seq 3))
- (should-not (seq--contains seq 7)))
- (with-test-sequences (seq '())
- (should-not (seq--contains seq 3))
- (should-not (seq--contains seq nil))))
+ (with-suppressed-warnings ((obsolete seq-contains))
+ (with-test-sequences (seq '(3 4 5 6))
+ (should (seq-contains seq 3))
+ (should-not (seq-contains seq 7)))
+ (with-test-sequences (seq '())
+ (should-not (seq-contains seq 3))
+ (should-not (seq-contains seq nil)))))
(ert-deftest test-seq-contains-should-return-the-elt ()
- (with-test-sequences (seq '(3 4 5 6))
- (should (= 5 (seq--contains seq 5)))))
+ (with-suppressed-warnings ((obsolete seq-contains))
+ (with-test-sequences (seq '(3 4 5 6))
+ (should (= 5 (seq-contains seq 5))))))
(ert-deftest test-seq-contains-p ()
(with-test-sequences (seq '(3 4 5 6))