diff options
| author | Mattias Engdegård <mattiase@acm.org> | 2019-05-21 12:19:38 +0200 |
|---|---|---|
| committer | Mattias Engdegård <mattiase@acm.org> | 2019-06-19 11:20:58 +0200 |
| commit | b8c74742c0238fe15b1cdc9a7f6ee021d038368f (patch) | |
| tree | d2d51fb226584f28017cb04ef8c3d173e83f1e87 /test/lisp/emacs-lisp | |
| parent | 36ab408207d7adf94fd1396922e0df38d746a948 (diff) | |
| download | emacs-b8c74742c0238fe15b1cdc9a7f6ee021d038368f.tar.gz emacs-b8c74742c0238fe15b1cdc9a7f6ee021d038368f.tar.bz2 emacs-b8c74742c0238fe15b1cdc9a7f6ee021d038368f.zip | |
Tighter pcase or-pattern member function selection (bug#36139)
* lisp/emacs-lisp/pcase.el (pcase--u1):
Use the most specific of `memq', `memql' and `member' in or-patterns
with constant cases. This improves performance and may help the byte-code
compiler generate a switch.
* test/lisp/emacs-lisp/pcase-tests.el (pcase-tests-member):
Add mixed-type or-pattern test cases.
Diffstat (limited to 'test/lisp/emacs-lisp')
| -rw-r--r-- | test/lisp/emacs-lisp/pcase-tests.el | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/test/lisp/emacs-lisp/pcase-tests.el b/test/lisp/emacs-lisp/pcase-tests.el index af8c9a3f3c3..e8c0b8219c5 100644 --- a/test/lisp/emacs-lisp/pcase-tests.el +++ b/test/lisp/emacs-lisp/pcase-tests.el @@ -51,9 +51,11 @@ (ert-deftest pcase-tests-member () (should (pcase-tests-grep - 'memql (macroexpand-all '(pcase x ((or 1 2 3) body))))) + 'memq (macroexpand-all '(pcase x ((or 'a 'b 'c) body))))) (should (pcase-tests-grep - 'member (macroexpand-all '(pcase x ((or "a" 2 3) body))))) + 'memql (macroexpand-all '(pcase x ((or 1 2 3 'a) body))))) + (should (pcase-tests-grep + 'member (macroexpand-all '(pcase x ((or "a" 2 3 'a) body))))) (should-not (pcase-tests-grep 'memq (macroexpand-all '(pcase x ((or "a" 2 3) body))))) (should-not (pcase-tests-grep |