diff options
| author | Keith Winstein <keithw@cs.stanford.edu> | 2023-03-14 16:00:25 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-14 16:00:25 -0700 |
| commit | 0ab3ee7d027e150a2beae13c849818a8fd0e0ffd (patch) | |
| tree | f78fe764e7567653c963ecabd177e5b551c91f5c /src/binary-reader-ir.cc | |
| parent | 6ec144e688cc76b6bf234fbc9c7ed7cee4a5c0c3 (diff) | |
| download | wabt-0ab3ee7d027e150a2beae13c849818a8fd0e0ffd.tar.gz wabt-0ab3ee7d027e150a2beae13c849818a8fd0e0ffd.tar.bz2 wabt-0ab3ee7d027e150a2beae13c849818a8fd0e0ffd.zip | |
BinaryReaderIR: increase kMaxNestingDepth to 16,384 (#2170)
Rationale: clang (compiled to Wasm) uses a label nesting depth of >1400,
which is greater than the limit of 1024 created in PR #2169.
In practice, with a debug build, values up to about 40,000 appear
sufficient to keep the stack within an 8 MiB limit. On release builds
it's more frugal and we could probably afford an even bigger limit. But,
"16384 ought to be enough nesting depth for anybody."
Diffstat (limited to 'src/binary-reader-ir.cc')
| -rw-r--r-- | src/binary-reader-ir.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/binary-reader-ir.cc b/src/binary-reader-ir.cc index dfe2f376..22280606 100644 --- a/src/binary-reader-ir.cc +++ b/src/binary-reader-ir.cc @@ -91,7 +91,7 @@ class CodeMetadataExprQueue { }; class BinaryReaderIR : public BinaryReaderNop { - static constexpr size_t kMaxNestingDepth = 1024; // max depth of label stack + static constexpr size_t kMaxNestingDepth = 16384; // max depth of label stack public: BinaryReaderIR(Module* out_module, const char* filename, Errors* errors); |