diff options
| author | Ng Zhi An <zhin@chromium.org> | 2021-08-06 09:53:03 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-08-06 09:53:03 -0700 |
| commit | dc91af683d4c5751a026b21e58e2f67be719e5c6 (patch) | |
| tree | 9acd8d2c7d536620bb42d070caeec8e19fd4ba4f /src/binary-reader-ir.cc | |
| parent | a92466a4dd1f5c2b8cb2fa05d3afa7e1f34e80af (diff) | |
| download | wabt-dc91af683d4c5751a026b21e58e2f67be719e5c6.tar.gz wabt-dc91af683d4c5751a026b21e58e2f67be719e5c6.tar.bz2 wabt-dc91af683d4c5751a026b21e58e2f67be719e5c6.zip | |
[simd] Correctly shift alignment_log2 (#1699)
The alignment value in binary format is log2, so we need to shift it in
binary-reader-ir before it is validated (since validation requires that
it is shifted to be the number of bytes). We correctly did that for some
Simd instructions (like load splat) but did not do it for load/store
lane.
Fixes #1674.
Diffstat (limited to 'src/binary-reader-ir.cc')
| -rw-r--r-- | src/binary-reader-ir.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/binary-reader-ir.cc b/src/binary-reader-ir.cc index 05b2d988..8290b95f 100644 --- a/src/binary-reader-ir.cc +++ b/src/binary-reader-ir.cc @@ -1086,7 +1086,7 @@ Result BinaryReaderIR::OnSimdLoadLaneExpr(Opcode opcode, Address offset, uint64_t value) { return AppendExpr( - MakeUnique<SimdLoadLaneExpr>(opcode, alignment_log2, offset, value)); + MakeUnique<SimdLoadLaneExpr>(opcode, 1 << alignment_log2, offset, value)); } Result BinaryReaderIR::OnSimdStoreLaneExpr(Opcode opcode, @@ -1094,7 +1094,7 @@ Result BinaryReaderIR::OnSimdStoreLaneExpr(Opcode opcode, Address offset, uint64_t value) { return AppendExpr( - MakeUnique<SimdStoreLaneExpr>(opcode, alignment_log2, offset, value)); + MakeUnique<SimdStoreLaneExpr>(opcode, 1 << alignment_log2, offset, value)); } Result BinaryReaderIR::OnSimdShuffleOpExpr(Opcode opcode, v128 value) { |