summaryrefslogtreecommitdiff
path: root/src/binary-reader-objdump.cc
diff options
context:
space:
mode:
authorSam Clegg <sbc@chromium.org>2022-02-09 16:40:24 -0800
committerGitHub <noreply@github.com>2022-02-09 16:40:24 -0800
commit11ed776f627535b4e851fcebfd52276de668f3f3 (patch)
tree962bb7b05201fe6d877f3f1ccf6f53200c1c3dd9 /src/binary-reader-objdump.cc
parentc2aec5aef9a476c5be41525236af259edb6aad6c (diff)
downloadwabt-11ed776f627535b4e851fcebfd52276de668f3f3.tar.gz
wabt-11ed776f627535b4e851fcebfd52276de668f3f3.tar.bz2
wabt-11ed776f627535b4e851fcebfd52276de668f3f3.zip
Fix size of segment in initialization error reporting (#1823)
When data of element segment init fails we were reporting the size, but we were unconditionally calling `Drop` for active segments which meant they always get reported as zero sized in the error message. This mismatch was only showing up with bulk memory enabled (since without this we do a two phase initialization). The only test we have for this error message was using `--disable-bulk-memory`, but not for any good reason (most likely because of this very bug). Also restore the comment about why we sometimes need to do a two phase initialization for element and data segments. This comment was lost in PR #1330 but seem important since I don't think we have any tests for this older behaviour.
Diffstat (limited to 'src/binary-reader-objdump.cc')
0 files changed, 0 insertions, 0 deletions