diff options
| author | Sam Clegg <sbc@chromium.org> | 2018-05-14 15:30:37 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-05-14 15:30:37 -0700 |
| commit | dd7663d78bf483308cd8d70d114748321f2cd61f (patch) | |
| tree | 9a255c8f91994618ada1572efff229088229a6f1 /src/binary-reader-objdump.cc | |
| parent | 17352a0aa4580ddf783cb0d9133ba5af9239b3f0 (diff) | |
| download | wabt-dd7663d78bf483308cd8d70d114748321f2cd61f.tar.gz wabt-dd7663d78bf483308cd8d70d114748321f2cd61f.tar.bz2 wabt-dd7663d78bf483308cd8d70d114748321f2cd61f.zip | |
wasm-objdump: Clearly distinguish undefined symbols in symbol table (#839)
Diffstat (limited to 'src/binary-reader-objdump.cc')
| -rw-r--r-- | src/binary-reader-objdump.cc | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/src/binary-reader-objdump.cc b/src/binary-reader-objdump.cc index ac814b40..8522a17a 100644 --- a/src/binary-reader-objdump.cc +++ b/src/binary-reader-objdump.cc @@ -1329,6 +1329,8 @@ void BinaryReaderObjdump::PrintSymbolFlags(uint32_t flags) { vis_name = "default"; break; } + if (flags & WABT_SYMBOL_FLAG_UNDEFINED) + PrintDetails(" undefined"); PrintDetails(" binding=%s vis=%s\n", binding_name, vis_name); } @@ -1338,8 +1340,7 @@ Result BinaryReaderObjdump::OnDataSymbol(Index index, Index segment, uint32_t offset, uint32_t size) { - char type_char = flags & WABT_SYMBOL_FLAG_UNDEFINED ? 'U' : 'D'; - PrintDetails(" - [%d] %c <" PRIstringview ">", index, type_char, + PrintDetails(" - [%d] D <" PRIstringview ">", index, WABT_PRINTF_STRING_VIEW_ARG(name)); if (!(flags & WABT_SYMBOL_FLAG_UNDEFINED)) PrintDetails(" segment=%" PRIindex " offset=%d size=%d", segment, offset, @@ -1352,14 +1353,13 @@ Result BinaryReaderObjdump::OnFunctionSymbol(Index index, uint32_t flags, string_view name, Index func_index) { - char type_char = flags & WABT_SYMBOL_FLAG_UNDEFINED ? 'U' : 'F'; std::string sym_name = name.to_string(); if (sym_name.empty()) { sym_name = GetFunctionName(func_index); } assert(!sym_name.empty()); - PrintDetails(" - [%d] %c <" PRIstringview "> func=%" PRIindex, index, - type_char, WABT_PRINTF_STRING_VIEW_ARG(sym_name), func_index); + PrintDetails(" - [%d] F <" PRIstringview "> func=%" PRIindex, index, + WABT_PRINTF_STRING_VIEW_ARG(sym_name), func_index); PrintSymbolFlags(flags); return Result::Ok; } @@ -1375,9 +1375,8 @@ Result BinaryReaderObjdump::OnGlobalSymbol(Index index, } } assert(!sym_name.empty()); - char type_char = flags & WABT_SYMBOL_FLAG_UNDEFINED ? 'U' : 'G'; - PrintDetails(" - [%d] %c <" PRIstringview "> global=%" PRIindex, index, - type_char, WABT_PRINTF_STRING_VIEW_ARG(sym_name), global_index); + PrintDetails(" - [%d] G <" PRIstringview "> global=%" PRIindex, index, + WABT_PRINTF_STRING_VIEW_ARG(sym_name), global_index); PrintSymbolFlags(flags); return Result::Ok; } |