Fix type names for function references (#1787)

This requires `Type::GetName` to return to be dynamicllay created and
return `std::string` rather then a `const char*`

As this diff shows this type name is only used in textual output and
error messages so should this change should not have a effect of binary
parse time or the interpreter.

1 files changed, 2 insertions, 2 deletions

diff --git a/src/binary-writer.cc b/src/binary-writer.cc
index af60f73d..d7b0154c 100644
--- a/src/binary-writer.cc
+++ b/src/binary-writer.cc
@@ -56,10 +56,10 @@ void WriteOpcode(Stream* stream, Opcode opcode) {
 }
 
 void WriteType(Stream* stream, Type type, const char* desc) {
-  WriteS32Leb128(stream, type, desc ? desc : type.GetName());
+  WriteS32Leb128(stream, type, desc ? desc : type.GetName().c_str());
   if (type.IsReferenceWithIndex()) {
     WriteS32Leb128(stream, type.GetReferenceIndex(),
-                   desc ? desc : type.GetName());
+                   desc ? desc : type.GetName().c_str());
   }
 }