Remove StringSlice (#576)

* Added StringTerminal only used by the lexer and parser, since we need an
  object that has a non-trivial constructor/destructor (so it can be
  included in the Token union).
* Name all terminal Token members with `t_` prefix
* Rename Literal -> LiteralTerminal, and only use for the lexer/parser.
* Move LiteralType to literal.h
* Use std::vector<std::string> for TextList and rename to TextVector
* Renamed CopyStringContents -> RemoveEscapes, and make it a template
  so it can write to a std::string and a std::vector.
* Rename DupTextList -> RemoveEscapes, and simplify it
  considerably.

1 files changed, 0 insertions, 4 deletions

diff --git a/src/binding-hash.h b/src/binding-hash.h
index 91c7ab35..04de1afd 100644
--- a/src/binding-hash.h
+++ b/src/binding-hash.h
@@ -58,10 +58,6 @@ class BindingHash : public std::unordered_multimap<std::string, Binding> {
     return FindIndex(name.to_string());
   }
 
-  Index FindIndex(const StringSlice& name) const {
-    return FindIndex(string_slice_to_string(name));
-  }
-
  private:
   typedef std::vector<const value_type*> ValueTypeVector;