summaryrefslogtreecommitdiff
path: root/src/circular-array.h
diff options
context:
space:
mode:
authorBen Smith <binji@chromium.org>2020-07-21 22:09:11 -0700
committerGitHub <noreply@github.com>2020-07-21 22:09:11 -0700
commitefee26853b4c7a3278b014db2fa0db13922f9e21 (patch)
treea0fb150195a5d41ee829c1bfe3740ec0be21c45d /src/circular-array.h
parentcd5ff133f84854f0b269f5cb06193ad8205f05d3 (diff)
downloadwabt-efee26853b4c7a3278b014db2fa0db13922f9e21.tar.gz
wabt-efee26853b4c7a3278b014db2fa0db13922f9e21.tar.bz2
wabt-efee26853b4c7a3278b014db2fa0db13922f9e21.zip
Fix resolving local names w/ empty func signatures (#1494)
This was originally landed in 6bff9f0, but was incorrect (the test didn't even do the right thing!) The problem was that the local index was correctly being updated, but it happened _after_ the names had already been resolved. To fix it, `ResolveFuncTypes` and `ResolveNamesModule` needed be called in that order. There was an erroneous assertion that fired as a result ("This should only be run after resolving names"), but that's incorrect -- the code works properly before resolving names too, since `Module::GetFuncType` can properly look up function types by name. Thanks to @alexcrichton for pointing this out.
Diffstat (limited to 'src/circular-array.h')
0 files changed, 0 insertions, 0 deletions