diff options
| author | Ben Smith <binji@chromium.org> | 2019-07-22 12:25:07 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-07-22 12:25:07 -0700 |
| commit | 890fba3f14b098bad6393f472fb1d49b417f4aeb (patch) | |
| tree | 35dbc0b002a12e14e3bf04711fbb10191f37b70f /src/config.h.in | |
| parent | 58e59b626b8fcf7973316eb84270c1887a8ac1f0 (diff) | |
| download | wabt-890fba3f14b098bad6393f472fb1d49b417f4aeb.tar.gz wabt-890fba3f14b098bad6393f472fb1d49b417f4aeb.tar.bz2 wabt-890fba3f14b098bad6393f472fb1d49b417f4aeb.zip | |
Change WABT_UNREACHABLE to call abort() (#1126)
Using __builtin_unreachable instead will basically produce undefined
behavior if it is ever reached, which makes it very difficult to debug.
This is perhaps desired for an optimized build, but certainly not for a
debug build.
For now, we'll always convert these to abort().
Diffstat (limited to 'src/config.h.in')
| -rw-r--r-- | src/config.h.in | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/src/config.h.in b/src/config.h.in index d2078c9a..136454db 100644 --- a/src/config.h.in +++ b/src/config.h.in @@ -18,6 +18,7 @@ #define WABT_CONFIG_H_ #include <stdint.h> +#include <stdlib.h> /* TODO(binji): nice way to define these with WABT_ prefix? */ @@ -57,8 +58,6 @@ #define alloca _alloca #elif defined(__MINGW32__) #include <malloc.h> -#else -#include <stdlib.h> #endif #if COMPILER_IS_CLANG || COMPILER_IS_GNU @@ -93,8 +92,6 @@ #define WABT_STATIC_ASSERT(x) _Static_assert((x), #x) #endif -#define WABT_UNREACHABLE __builtin_unreachable() - #elif COMPILER_IS_MSVC #include <intrin.h> @@ -108,14 +105,14 @@ #define WABT_LIKELY(x) (x) #define WABT_PRINTF_FORMAT(format_arg, first_arg) -#define WABT_UNREACHABLE __assume(0) - #else #error unknown compiler #endif +#define WABT_UNREACHABLE abort() + #ifdef __cplusplus namespace wabt { |