diff options
| author | Keith Winstein <keithw@cs.stanford.edu> | 2023-08-23 13:49:40 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-08-23 20:49:40 +0000 |
| commit | ba73887a5abf5bb40b564a55a61d3970d1e394f6 (patch) | |
| tree | 20d797e80d810c451f34098f9e90bd44db4757d1 /src | |
| parent | 7eb5868cf0c37c2fe800fa92017fc063bc8fb991 (diff) | |
| download | wabt-ba73887a5abf5bb40b564a55a61d3970d1e394f6.tar.gz wabt-ba73887a5abf5bb40b564a55a61d3970d1e394f6.tar.bz2 wabt-ba73887a5abf5bb40b564a55a61d3970d1e394f6.zip | |
Validator: normalize handling of Select in ExprVisitor Delegate (#2285)
Fixes #2283
Previously, the OnSelectExpr delegate would terminate validation if the
SharedValidator found an error in the expression, or if the Validator
had previously found an error at any point in validating the module.
This commit normalizes the behavior to match how the Validator handles
other expression types.
Diffstat (limited to 'src')
| -rw-r--r-- | src/validator.cc | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/src/validator.cc b/src/validator.cc index ade15462..d52efb97 100644 --- a/src/validator.cc +++ b/src/validator.cc @@ -524,12 +524,7 @@ Result Validator::OnReturnCallIndirectExpr(ReturnCallIndirectExpr* expr) { Result Validator::OnSelectExpr(SelectExpr* expr) { result_ |= validator_.OnSelect(expr->loc, expr->result_type.size(), expr->result_type.data()); - // TODO: Existing behavior fails when select fails. -#if 0 return Result::Ok; -#else - return result_; -#endif } Result Validator::OnStoreExpr(StoreExpr* expr) { |