diff options
| author | Sam Clegg <sbc@chromium.org> | 2021-10-13 09:16:02 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-10-13 09:16:02 -0700 |
| commit | e1b6676d09c315dc974670a0b364143f39d3a7d7 (patch) | |
| tree | a67cc8434f9aaa8743fa0a59db709f49cea26090 /test/spec/bulk-memory-operations/memory_init.txt | |
| parent | f64f393ff0bad3a33e97084ce63dcf18b13f335c (diff) | |
| download | wabt-e1b6676d09c315dc974670a0b364143f39d3a7d7.tar.gz wabt-e1b6676d09c315dc974670a0b364143f39d3a7d7.tar.bz2 wabt-e1b6676d09c315dc974670a0b364143f39d3a7d7.zip | |
Avoid writing DataCount section when it is not needed. (#1727)
Without this change, when bulk memory is enabled, the DataCount is
always written when then removed if it proves that its not needed by any
instruction.
However, if we know there are no data segments we can avoid writing it
altogether. This happens to be more compact but I'm hoping to land this
now in anticipation of enabled bulk memory by default. Once we do that
we don't want all the `dump` tests to include the writing and truncating
of the DataCount section in cases when there is no data.
Diffstat (limited to 'test/spec/bulk-memory-operations/memory_init.txt')
| -rw-r--r-- | test/spec/bulk-memory-operations/memory_init.txt | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/test/spec/bulk-memory-operations/memory_init.txt b/test/spec/bulk-memory-operations/memory_init.txt index f1adba60..db19a6df 100644 --- a/test/spec/bulk-memory-operations/memory_init.txt +++ b/test/spec/bulk-memory-operations/memory_init.txt @@ -7,8 +7,7 @@ test() => test() => test() => out/test/spec/bulk-memory-operations/memory_init.wast:189: assert_invalid passed: - 0000000: error: data_segment variable out of range: 0 (max 0) - 0000027: error: OnDataDropExpr callback failed + 0000023: error: data.drop requires data count section out/test/spec/bulk-memory-operations/memory_init.wast:195: assert_invalid passed: 0000000: error: data_segment variable out of range: 4 (max 1) 000002c: error: OnDataDropExpr callback failed @@ -16,9 +15,7 @@ test() => out/test/spec/bulk-memory-operations/memory_init.wast:216: assert_trap passed: out of bounds memory access: memory.init out of bounds out/test/spec/bulk-memory-operations/memory_init.wast:223: assert_trap passed: out of bounds memory access: memory.init out of bounds out/test/spec/bulk-memory-operations/memory_init.wast:226: assert_invalid passed: - error: memory variable out of range: 0 (max 0) - 0000000: error: data_segment variable out of range: 1 (max 0) - 000002f: error: OnMemoryInitExpr callback failed + 000002a: error: memory.init requires data count section out/test/spec/bulk-memory-operations/memory_init.wast:232: assert_invalid passed: 0000000: error: data_segment variable out of range: 1 (max 1) 0000034: error: OnMemoryInitExpr callback failed |