diff options
| author | Sam Clegg <sbc@chromium.org> | 2022-03-02 17:07:36 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-03-02 17:07:36 -0800 |
| commit | e385ff4b792aa5497471d80f863e7436fc6a110a (patch) | |
| tree | d0d699011a359fe29d07920e914e221fec8d001f /test/spec/nop.txt | |
| parent | 1dea1ee053cd9de4345ada0cf0b197066f92968b (diff) | |
| download | wabt-e385ff4b792aa5497471d80f863e7436fc6a110a.tar.gz wabt-e385ff4b792aa5497471d80f863e7436fc6a110a.tar.bz2 wabt-e385ff4b792aa5497471d80f863e7436fc6a110a.zip | |
Fix function body start/end locations in wasm-validate (#1842)
For text validation, this means the error is always correctly reported on
the final expression in the function.
For binary validation, this means that we report the byte after the last
instruction in the function as the failure location. This is in line
with other binary validation reports. For example, for `type mismatch
in i32.add` we report the validation error at the byte *after* the add
instruction.
Diffstat (limited to 'test/spec/nop.txt')
| -rw-r--r-- | test/spec/nop.txt | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/test/spec/nop.txt b/test/spec/nop.txt index c9b3b32b..261d1b95 100644 --- a/test/spec/nop.txt +++ b/test/spec/nop.txt @@ -2,16 +2,16 @@ ;;; STDIN_FILE: third_party/testsuite/nop.wast (;; STDOUT ;;; out/test/spec/nop.wast:412: assert_invalid passed: - out/test/spec/nop/nop.1.wasm:0000019: error: type mismatch in implicit return, expected [i32] but got [] + out/test/spec/nop/nop.1.wasm:000001a: error: type mismatch in implicit return, expected [i32] but got [] 000001a: error: EndFunctionBody callback failed out/test/spec/nop.wast:416: assert_invalid passed: - out/test/spec/nop/nop.2.wasm:0000019: error: type mismatch in implicit return, expected [i64] but got [] + out/test/spec/nop/nop.2.wasm:000001a: error: type mismatch in implicit return, expected [i64] but got [] 000001a: error: EndFunctionBody callback failed out/test/spec/nop.wast:420: assert_invalid passed: - out/test/spec/nop/nop.3.wasm:0000019: error: type mismatch in implicit return, expected [f32] but got [] + out/test/spec/nop/nop.3.wasm:000001a: error: type mismatch in implicit return, expected [f32] but got [] 000001a: error: EndFunctionBody callback failed out/test/spec/nop.wast:424: assert_invalid passed: - out/test/spec/nop/nop.4.wasm:0000019: error: type mismatch in implicit return, expected [f64] but got [] + out/test/spec/nop/nop.4.wasm:000001a: error: type mismatch in implicit return, expected [f64] but got [] 000001a: error: EndFunctionBody callback failed 87/87 tests passed. ;;; STDOUT ;;) |