summaryrefslogtreecommitdiff
path: root/src/validator.cc
Commit message (Collapse)AuthorAgeFilesLines
* binary/wat: Implement EHv4 (#2470)Soni L.2024-11-201-0/+24
| | | | This pull request implements EHv4. Binary is mostly untested until interp is working.
* Add support for the custom-page-sizes proposal (#2502)Keith Winstein2024-11-081-2/+4
| | | | This adds support in the binary/text parsers and writers, the validator and interpreter, and objdump (but not wasm2c).
* Update testsuite and implement table64 (#2418)Sam Clegg2024-05-151-1/+7
| | | | | See https://github.com/WebAssembly/memory64/issues/51 Includes workaround for #2422
* Flip order of memory indexes on memory.copy (#2294)Keith Winstein2023-09-111-1/+1
| | | | Reflects change in the multi-memory proposal: https://github.com/WebAssembly/multi-memory/pull/29
* Share reading/validation code between elem exprs & other const exprs (#2288)Keith Winstein2023-09-061-18/+5
| | | | | | This continues the work from #1783 and reduces special handling of elem exprs, by treating them the same as other const expressions (init expressions).
* Validator: normalize handling of Select in ExprVisitor Delegate (#2285)Keith Winstein2023-08-231-5/+0
| | | | | | | | | Fixes #2283 Previously, the OnSelectExpr delegate would terminate validation if the SharedValidator found an error in the expression, or if the Validator had previously found an error at any point in validating the module. This commit normalizes the behavior to match how the Validator handles other expression types.
* memory64: when enabled, check offset range at validation-time (#2253)Keith Winstein2023-06-121-16/+25
| | | | | | | | | | | | | | | | * memory64: when enabled, offset range check is at validation-time Before memory64, the "offset" in a load/store expression was a u32, and we enforced this in the WastParser and BinaryReader. After memory64, the "offset" becomes a u64 syntactically, and the validator checks that it's <= UINT32_MAX for i32 memories. We hadn't been correctly allowing these very large offsets in the text format (even when memory64 was enabled and the memory was i64). (This change also eliminates the "memories" member in the BinaryReader. The BinaryReader no longer needs to keep track of the memories and their types to check well-formedness.)
* Make sure (IR) Validator and BinaryReaderInterp agree re: validity (#2219)Keith Winstein2023-04-271-2/+2
| | | | Fixes one issue where Validator was incorrectly accepting some malformed modules from the spec tests.
* Implement Relaxed SIMD proposal (#1994)Marcus Better2022-11-301-8/+46
| | | | | | | | This adds support for the new opcodes from the Relaxed SIMD proposal (https://github.com/WebAssembly/relaxed-simd) behind the "--enable-relaxed-simd" flag. The exception is the f32x4.relaxed_dot_bf16x8_add_f32x4 instruction which is not yet implemented.
* Update testsuite (#2054)Sam Clegg2022-11-131-1/+2
| | | | | | | | | | | | | | | As well as the testsuite update there are two notable changes that come with it here. These can both be split out an landed first if it makes sense. 1. wasm2c now supports element sections containing externref. Currently only the null reference is supported. 2. element segments no longer use funcref as the default element type but instead, unless explicitly included in the binary, the element type defaults to the type of the table in which the segment is active. Fixes: #1612 #2022
* Move headers to include/wabt/ (#1998)Alex Reinking2022-09-281-7/+7
| | | This makes things easier for users and packagers of libwabt.
* Support multi-memory in all memory ops and in apply/resolve-names (#1962)Keith Winstein2022-08-151-11/+12
|
* Track locations of Vars in BinaryReaderIR and BinaryReaderInterp (#1963)Keith Winstein2022-08-151-1/+1
| | | | - Rebase test output to match new location tracking on Vars - Eliminate single-argument Var() constructor.
* wast2json: write binary modules verbatim (#1932)Ben Smith2022-06-031-0/+7
| | | | | | | | | | | | | | Previously any top-level module defined in a .wast file would be parsed and converted to a `Module` and stored in a `ModuleCommand`, since it may be used later by the script (e.g. via an `invoke` command). This means that when it was written out later it may have been changed, which is undesirable for binary and quoted modules. This change adds a new `ScriptModuleCommand`, which stores both a `Module` and a `ScriptModule`. The `Module` contains the parsed information, and the `ScriptModule` contains the original contents of the binary or quoted data. This fixes issue #1927.
* Fix function body start/end locations in wasm-validate (#1842)Sam Clegg2022-03-021-4/+6
| | | | | | | | | | For text validation, this means the error is always correctly reported on the final expression in the function. For binary validation, this means that we report the byte after the last instruction in the function as the failure location. This is in line with other binary validation reports. For example, for `type mismatch in i32.add` we report the validation error at the byte *after* the add instruction.
* Add initial support for code metadata (#1840)Yuri Iozzelli2022-02-251-0/+5
| | | | | | | | | | | | | | | | | | | | | See https://github.com/WebAssembly/tool-conventions/blob/main/CodeMetadata.md for the specification. In particular this pr implements the following: - Parsing code metadata sections in BinaryReader, providing appropriate callbacks that a BinaryReaderDelegate can implement: - BinaryReaderObjdump: show the sections in a human-readable form - BinaryReaderIr: add code metadata in the IR as expressions - Parsing code metadata annotations in text format, adding them in the IR like the BinaryReaderIR does - Writing the code metadata present in the IR in the proper sections when converting IR to binary - Support in wasm-decompiler for showing code metadata as comments in the pseudo-code All the features have corresponding tests. Support for code metadata is gated through the --enable-code-metadata feature. For reading/writing in the text format, --enable-annotations is also required. Missing features: Support for function-level code metadata (offset 0) Extensive validation in validator.cc (like making sure that all metadata instances are at the same code offset of an instruction)
* Clang-format codebase (#1684)Heejin Ahn2021-12-201-7/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This applies clang-format to the whole codebase. I noticed we have .clang-format in wabt but the codebase is not very well formatted. This kind of mass-formatting PR has fans and skeptics because it can mess with `git blame`, but we did a similar thing in Binaryen a few years ago (WebAssembly/binaryen#2048, which was merged in WebAssembly/binaryen#2059) and it was not very confusing after all. If we are ever going to format the codebase, I think it is easier to do it in a single big PR than dozens of smaller PRs. This is using the existing .clang-format file in this repo, which follows the style of Chromium. If we think this does not suit the current formatting style, we can potentially tweak .clang-format too. For example, I noticed the current codebase puts many `case` statements within a single line when they are short, but the current .clang-format does not allow that. This does not include files in src/prebuilt, because they are generated. This also manually fixes some comment lines, because mechanically applying clang-format to long inline comments can look weird. I also added a clang-format check hook in the Github CI in #1683, which I think can be less controversial, given that it only checks the diff. --- After discussions, we ended up reverting many changes, especially one-liner functions and switch-cases, which are too many to wrap in `// clang-format off` and `// clang-format on`. I also considered fixing `.clang-format` to allow those one-liners but it caused a larger churn in other parts. So currently the codebase does not conform to `.clang-format` 100%, but we decided it's fine.
* Fix type names for function references (#1787)Sam Clegg2021-12-131-1/+2
| | | | | | | | This requires `Type::GetName` to return to be dynamicllay created and return `std::string` rather then a `const char*` As this diff shows this type name is only used in textual output and error messages so should this change should not have a effect of binary parse time or the interpreter.
* Share validation code between constant expressions and function bodies. NFC ↵Sam Clegg2021-12-101-75/+23
| | | | | | | | | | | | (#1783) Previously we has special cases for initializer expressions (constant expressions). This change paves the way for adding support for extended constant expressions that support a wider range of instructions. This change removes twice as many lines as it adds which shows that this simplification is probably worthwhile even without the pending extensions.
* Add specification tests for exception handling proposal (#1764)Asumu Takikawa2021-12-061-0/+4
| | | | | | | | This PR imports the spec tests from the Wasm testsuite repo and adds infrastructure to run them correctly. * Adds test expectations for exception handling proposal spec tests. * Adds missing tag signature matching code for import tests. * Adds support for the `assert_exception` command used in new tests. * Fix filename normalization for the spec test runner.
* Add multi-memory feature support (#1751)Yuhan Deng2021-11-301-7/+8
|
* Support function references in parameters and results of functions and ↵Dmitry Bezhetskov2021-11-161-5/+6
| | | | blocks. (#1695)
* Delay validation of elem init expressions until validation time (#1730)Sam Clegg2021-10-141-14/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Doing validation at parse time means we cannot run tests which included invalid instruction in the elem init expressions. For example. the updated test suite repo contains tests such as this: ``` (assert_invalid (module (table 1 funcref) (elem (i32.const 0) funcref (item (i32.add (i32.const 0) (i32.const 1)))) ) "constant expression required" ) ``` There we have an illegal instruction sequence in the init expresssion. However, in order to run this test we need to be able to process it with wast2json first which means it at least has to parse correctly. This change removes the `ElemExpr` and `ElemExprKind` types from the IR and instead just stores elem init expressions as `ExprList` like we do for global init expressions. This expression list can then be validated but crucially can also be invalid. This technique matches the existing `OnDataSegmentInitExpr_Other` and `OnGlobalInitExpr_Other` and indeed it seem that it was indented to work this way since the `OnElemSegmentElemExpr_Other` already existed (unused) in the codebase.
* Begin support for typed function references proposal: added the flag and ↵Dmitry Bezhetskov2021-07-251-0/+12
| | | | supported call_ref (#1691)
* [EH] Remove `unwind` (#1682)Heejin Ahn2021-06-291-6/+0
| | | `unwind` was removed. See WebAssembly/exception-handling#156.
* [EH] Replace event with tag (#1678)Heejin Ahn2021-06-221-8/+8
| | | | | | | | | | | We recently decided to change 'event' to 'tag', and 'event section' to 'tag section', out of the rationale that the section contains a generalized tag that references a type, which may be used for something other than exceptions, and the name 'event' can be confusing in the web context. See - https://github.com/WebAssembly/exception-handling/issues/159#issuecomment-857910130 - https://github.com/WebAssembly/exception-handling/pull/161
* [simd] Implement store lane (#1647)Ng Zhi An2021-03-221-0/+8
|
* [simd] Implement load lane (#1646)Ng Zhi An2021-03-221-0/+8
| | | | | | | | | This is a new kind of ir/ast node/instruction. It has 3 immediates: memarg align, memarg offset, and lane index. This required new visitor functions in all the places. Drive-by cleanup to share the simd lane parsing logic between shuffle, lane op and this new load lane instructions. This requires rebasing some tests because the error messages are slightly different now.
* [simd] Implement v128.load{32,64}_zero (#1644)Ng Zhi An2021-03-171-0/+7
| | | | This requires a new ir type, and the relevant implementation of virtual mthods in the various visitors.
* Update exception handling support to current proposal (#1596)Asumu Takikawa2021-02-101-11/+17
| | | | | | | | | | This PR updates the support of exception handling to the latest proposal (that is compatible with future 2-phase exception handling) described in https://github.com/WebAssembly/exception-handling/pull/137 and https://github.com/WebAssembly/exception-handling/pull/143. * Adds back tagged `catch $e`, `catch_all`, and `rethrow N` from a previous version of wabt, but with updates to match the current spec (e.g., `catch_all` shares an opcode with `else`, `rethrow`'s depth indexes only catch blocks, etc). * Adds `unwind` and `delegate` instructions. * Removes `exnref` and `br_on_exn`. * Updates relevant tests. There are some details that could still change (e.g., maybe how `delegate`'s depth is validated), but I'd be happy to submit further PRs if the spec details change.
* Select instr. with multiple results is invalid (#1582)Ben Smith2020-12-031-7/+2
| | | | | | The reference-types proposal adds a select instruction with a type vector, but any number greater than 1 is invalid. Fixes #1577.
* Remove ref.is_null type parameter (#1474)Ben Smith2020-07-151-1/+1
| | | | | | | | | See https://github.com/WebAssembly/reference-types/issues/99. This change also updates the testsuite, so the spec tests pass too. In addition, the behavior of `br_table` is no longer different from MVP, and has a text to confirm this. That is now fixed in `type-checker.cc` too.
* [wasm2wat] Write select type immediate (#1451)Ben Smith2020-05-291-2/+7
| | | | | | | | | | | | | | | The main fix is in `wat-writer.cc`, where the type immediate was never being printed. But I've also included a change to how `select` type immediates are represented in wabt. Previously, a bare `select` instruction would be stored with the type `Type::Any`. This is not a real wasm type, and is primarily used for type validation. The spec instead considers this form of `select` to have an empty type immediate, which is closer to the `Type::Void` type. This commit now uses `Type::Void` (or an empty `TypeVector`) to represent the bare `select` instruction. Fixes #1444.
* Reference types changes to remove subtyping (#1407)Ben Smith2020-05-281-4/+6
| | | | | | | | Main changes: * Rename `anyref` -> `externref` * Remove `nullref` * Rename `hostref` -> `externref` * `ref.null` and `ref.is_null` now have "ref kind" parameter * Add ref kind keywords: `func`, `extern`, `exn`
* Add support for atomic.fence from the threads proposal (#1231)Andy Wingo2020-04-201-0/+6
| | | | | See https://github.com/WebAssembly/threads/pull/141 for the binary encoding. This patch does add a field to AtomicFenceExpr for the consistency model, though without a type for the time being.
* Parse ArrayTypes (#1364)Ben Smith2020-03-231-0/+8
| | | | | | | | | | The following formats are supported: * (type (array i32)) * (type (array (field i32))) * (type (array (field (mut i32)))) This PR adds support for reading/writing binary and text, but no interpreter support yet.
* Refactor Const struct's internal storage (#1356)Ben Smith2020-03-161-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Const previously stored each value as a union of bit patterns (uint32_t, uint64_t, v128, etc). It was then extended to support cases where NaN value (either arithmetic or canonical) was expected. bool is_expected_nan; union { uint32_t u32; uint32_t f32_bits; ... ExpectedNan expected; } With the SIMD proposal, it's possible for each lane of a f32x4 or f64x2 to be a float or an expected NaN, so this doesn't work anymore. It's possible to move ExpectedNan out of the union, but it's a bit clumsy to use properly: bool is_expected_nan[4]; ExpectedNan expected[4]; union { ... } Instead, I took this as an opportunity to clean up the class a bit. First, ExpectedNan is extended to handle the case where it is not a NaN (i.e. not a not a number), which allows us to remove the bool. Then I store the rest of the data as an array of `uint32_t`, and provide accessor functions instead.
* Parse struct fields (#1355)Ben Smith2020-03-161-1/+7
| | | | | | | | | | | This allows the following field formats: * `(struct (field $name i32))` * `(struct (field $name (mut i32)))` * `(struct (field i32))` * `(struct (field (mut i32)))` * `(struct (mut i32))` * `(struct i32)`
* Initial pass parsing/reading struct (#1352)Ben Smith2020-03-091-5/+10
| | | | | | | | | | | | | | | | | | This parses just the format `(struct)` as a new type. I added a test for this using `wat2wasm`, but that requires a rudimentary binary format. The test runner automatically attempts to rountrip all wat2wasm tests, so this required implementing the wat writing and binary reading too. Here's a summary of the changes: * binary-reader:h: Rename `BinaryReader::OnType` callbacks to `OnFuncType` * binary-reader.h: Add `BinaryReader::OnStructType` * binary-reader.cc: Use a switch after reading the type form to determine whether we're reading a function or struct. * tokens.def: Add new `TokenType::Struct` * lexer-keywords.txt: Add new `struct` keyword * type.h: Add `Type::Struct` type form * wast-parser.cc: Parse `(struct)` in text format * wat-writer.cc: Write Func or Struct type forms
* Fix TODOs in validator; only affects error outputBen Smith2020-02-291-2/+0
| | | | | | The major change to the error output is showing the max value instead of max value - 1. It's a bit weird to see "out of range: 0 (max 0)" but seeing 4294967295 is strictly worse.
* Convert Type from an enum into a class (#1350)Ben Smith2020-02-281-3/+3
| | | | | | | | | | | | | | | | | This is similar to the way Opcode is structured, which allows us to hang member functions off of the enumeration. The primary motivator for this change is the GC proposal (and the function-references proposal) where a Type can be parameterized: (type $T (struct ...)) (func (local (ref $T) ... ) In this case the type is ref, with a parameter of the type index. Making Type a class will make it easier to store this additional information.
* Update testsuite (w/ reference-types changes) (#1351)Ben Smith2020-02-281-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The new table-sub test, checks whether the subtyping is handled properly w/ table.init and table.copy instructions. The BeginElemSegment callback can't pass the element type anymore, since it's not known yet. The callback also can't be deferred, since the BeginElemSegmentInitExpr callback has to happen after the BeginElemSegment callback, but the reference type is not always known until after the initializer expression is read. To work around this, I added a new OnElemSegmentElemType callback. Other element segment changes: * The element type must be tracked in the SharedValidator * A subtle fix: when writing out the segment flags, we need to take into account whether the element type of the segment is not funcref, even if there are no element expressions. In that case, we have to use flag bit 0x4 (SegUseElemExprs). In addition, the TableCopy and TableInit instructions weren't handling table indexes fully. * TableCopy variables are read in the parser (both optional) * TableCopy names are now resolved + applied * TableCopy indexes are now validated * TableInit table variables are read in the parser; this is subtle, since the text format has order $table $segment, but the $table is optional.
* Add TypeEntry, base class for type section entries (#1349)Ben Smith2020-02-281-6/+12
| | | | | | | | | | | The type section currently only has one form: functions. With the GC proposal, at least two more forms are added: struct and array. To facilitate this: * Rename FuncTypeModuleField -> TypeModuleField * Rename Module::func_types -> Module::types * Rename func_type_bindings -> type_bindings * TypeEntry is added as a base class of FuncType * TypeModuleField stores a unique_ptr to a TypeEntry
* Share validator between IR + binary-reader-interp (#1346)Ben Smith2020-02-271-927/+381
| | | | | | | | | | | | | | | | | | | | | | | | | | | The TypeChecker was already shared, but the rest of the other validation logic was duplicated. This change creates a SharedValidator which is used by both the Validator and the BinaryReaderInterp classes. The validator is structured similarly to TypeChecker as a collection of functions. It's assumed that the functions will be called in the same order as sections occur in the binary format. The IR valiator does this too, even though it's possible to validate components out-of-order in that case. This change also splits Module validation and Script validation into two different classes. It should have been written this way in the first place, and it's nice to do as part of this change since the module validator logic is mostly moved into the SharedValidator anyway. Next steps: * Remove all validation from BinaryReader and move it into the SharedValidator. * Move the TypeChecker into the SharedValidator (maybe not necessary) * Ensure that validation occurs before creating IR from binary (use SharedValidator in BinaryReaderIR? or maybe create BinaryReaderValidator passthru that both BinaryReaderIR and BinaryReaderInterp use?) * Rename Validator -> IRValidator, SharedValidator -> Validator
* Move validation of func signatures into the parser (#1341)Ben Smith2020-02-251-110/+2
| | | | | | The previous PR called the validator function to do this, but now the code is moved entirely into the parser. This is preferable, since a mismatching function signature is considered malformed text, not a validation error.
* Update testsuite (#1327)Sam Clegg2020-02-051-3/+42
| | | | | The main change here is the addition of declared elem sections.
* Update testsuite (#1308)Ben Smith2020-01-161-7/+0
| | | | | | | | | | * Remove `assert_return_func`. This is now handled by using `assert_return` with `(ref.func)`. * The reference types proposal depends on the bulk memory proposal, so using `--enable-reference-types` automatically includes `--enable-bulk-memory`. * `table.fill` no longer clamps to the valid range, and instead checks before writing anything. This matches the other bulk instructions.
* Update testsuite (#1275)Sam Clegg2020-01-091-48/+0
| | | | | | | | | | | | | | | | | The two primary changes involved are: 1. Removal of `assert_return_canonical_nan`/`arithetic nan` in favor of special `nan:canonical`/`nan:arithmetic` constants that can only be used in test expectations. See: https://github.com/WebAssembly/spec/pull/1104 2. New trapping behaviour for bulk memory operations. Range checks are now performed up front for opterations such as memory.fill and memory.copy. See: https://github.com/webassembly/bulk-memory-operations/issues/111 And: https://github.com/webassembly/bulk-memory-operations/pull/123 The old behaviour is still kept around to support table.fill which is defined in reference-types proposal and has yet to be updated.
* Segment flags should be MVP-compat when possible (#1286)Ben Smith2020-01-081-2/+10
| | | | This should fix #1280, #1268, #1269.
* Several fixes for reference types (#1278)Heejin Ahn2020-01-081-2/+2
| | | | | | | - Allow `ref.func` for global initialization expressions - Allow `nullref` as a full-fledged type, after WebAssembly/reference-types#66 - Enable reference types when exnref is used (The reference types proposal is a prerequisite of the EH proposal)
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-05 00:55:05 +0000