diff options
author | Fabio Alessandrelli <fabio.alessandrelli@gmail.com> | 2023-12-21 19:05:53 +0100 |
---|---|---|
committer | Fabio Alessandrelli <fabio.alessandrelli@gmail.com> | 2023-12-22 01:30:01 +0100 |
commit | b0efc17d3b898206c2e1c98ad4884e404808c854 (patch) | |
tree | 8fe3c7cc594db1ee2b07fb391002870440e65880 /SConstruct | |
parent | ec0ededcdef7512517aa7aaa9bd49652cece4770 (diff) | |
download | fork-godot-webrtc-native-b0efc17d3b898206c2e1c98ad4884e404808c854.tar.gz fork-godot-webrtc-native-b0efc17d3b898206c2e1c98ad4884e404808c854.tar.bz2 fork-godot-webrtc-native-b0efc17d3b898206c2e1c98ad4884e404808c854.zip |
[Linux] Only export extension init symbol
Since we link with static libstdc++ we need to tell gcc to only export
the necessary symbols.
Using "-fvisibility=hidden" will not work, since libstdc++ explicitly
exports its symbols.
Diffstat (limited to 'SConstruct')
-rw-r--r-- | SConstruct | 31 |
1 files changed, 19 insertions, 12 deletions
@@ -120,18 +120,6 @@ if env["platform"] == "macos" and os.environ.get("OSXCROSS_ROOT", ""): if env["macos_deployment_target"] != "default": env["ENV"]["MACOSX_DEPLOYMENT_TARGET"] = env["macos_deployment_target"] -# Patch linux flags to statically link libgcc and libstdc++ -if env["platform"] == "linux": - env.Append( - LINKFLAGS=[ - "-Wl,--no-undefined", - "-static-libgcc", - "-static-libstdc++", - ] - ) - # And add some linux dependencies. - env.Append(LIBS=["pthread", "dl"]) - opts.Update(env) target = env["target"] @@ -175,6 +163,24 @@ rtc = env.BuildLibDataChannel(ssl) # but it's better to be safe in case of indirect inclusions by one of our other dependencies. env.Depends(sources, ssl + rtc) +# We want to statically link against libstdc++ on Linux to maximize compatibility, but we must restrict the exported +# symbols using a GCC version script, or we might end up overriding symbols from other libraries. +# Using "-fvisibility=hidden" will not work, since libstdc++ explicitly exports its symbols. +symbols_file = None +if env["platform"] == "linux": + if env["godot_version"] == "3": + symbols_file = env.File("misc/dist/linux/symbols-gdnative.map") + else: + symbols_file = env.File("misc/dist/linux/symbols-extension.map") + env.Append( + LINKFLAGS=[ + "-Wl,--no-undefined,--version-script=" + symbols_file.abspath, + "-static-libgcc", + "-static-libstdc++", + ] + ) + env.Depends(sources, symbols_file) + # Make the shared library result_name = "libwebrtc_native{}{}".format(env["suffix"], env["SHLIBSUFFIX"]) if env["godot_version"] != "3" and env["platform"] == "macos": @@ -190,6 +196,7 @@ if env["godot_version"] != "3" and env["platform"] == "macos": library = [library_file, plist_file] else: library = env.SharedLibrary(target=os.path.join(result_path, "lib", result_name), source=sources) + Default(library) # GDNativeLibrary |