summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDerek Schuff <dschuff@chromium.org>2021-01-14 15:57:52 -0800
committerGitHub <noreply@github.com>2021-01-14 15:57:52 -0800
commitf18c18e01d03d6d293fe3d701408855bbcea58bd (patch)
treea95562bfd03715192f57b775ba9ff1888f449fba
parentd94982319a6904f81a7f615c6fc9ea4f88f3c820 (diff)
downloadbinaryen-f18c18e01d03d6d293fe3d701408855bbcea58bd.tar.gz
binaryen-f18c18e01d03d6d293fe3d701408855bbcea58bd.tar.bz2
binaryen-f18c18e01d03d6d293fe3d701408855bbcea58bd.zip
Enable LTO on the Linux Clang build on CI (#3491)
Also adjust the check for Clang to also match AppleClang
-rw-r--r--.github/workflows/ci.yml6
-rw-r--r--CMakeLists.txt2
2 files changed, 4 insertions, 4 deletions
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 961dfff7a..23c94478e 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -101,7 +101,7 @@ jobs:
run: python check.py --binaryen-bin=out/bin
build-clang:
- name: clang
+ name: clang (LTO)
runs-on: ubuntu-latest
steps:
- uses: actions/setup-python@v1
@@ -115,9 +115,9 @@ jobs:
- name: cmake
run: |
mkdir -p out
- cmake -S . -B out -G Ninja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++
+ cmake -S . -B out -G Ninja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DBYN_ENABLE_LTO=ON
- name: build
- run: cmake --build out
+ run: cmake --build out -v
- name: test binaryen-lit
run: python out/bin/binaryen-lit test/lit/parse-error.wast
- name: test
diff --git a/CMakeLists.txt b/CMakeLists.txt
index b9120d557..f1ff8fbbe 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -137,7 +137,7 @@ ENDFOREACH()
option(BYN_ENABLE_LTO "Build with LTO" Off)
if(BYN_ENABLE_LTO)
- if(NOT CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
+ if(NOT CMAKE_CXX_COMPILER_ID MATCHES "Clang")
message(FATAL_ERROR "ThinLTO is only supported by clang")
endif()
if(NOT APPLE)