[NFC] Refactor LocalGraph's core getSets API (#6877)

Before we just had a map that people would access with localGraph.getSetses[get],
while now it is a call localGraph.getSets(get), which more nicely hides the internal
implementation details.

Also rename getSetses => getSetsMap.

This will allow a later PR to optimize the internals of this API.

This is performance-neutral as far as I can measure. (We do replace a direct read
from a data structure with a call, but the call is in a header and should always get
inlined.)

1 files changed, 5 insertions, 5 deletions

diff --git a/src/analysis/reaching-definitions-transfer-function.h b/src/analysis/reaching-definitions-transfer-function.h
index dcf04e377..7a4fe1afc 100644
--- a/src/analysis/reaching-definitions-transfer-function.h
+++ b/src/analysis/reaching-definitions-transfer-function.h
@@ -42,7 +42,7 @@ class ReachingDefinitionsTransferFunction
   std::unordered_map<Index, SmallVector<LocalSet*, 2>> indexSetses;
 
   // LocalGraph members we need to update.
-  LocalGraph::GetSetses& getSetses;
+  LocalGraph::GetSetsMap& getSetsMap;
 
   // Fictitious LocalSet objects to reprsent a local index obtaining its value
   // from its default initial value or parameter value.
@@ -86,9 +86,9 @@ public:
   // are working with doesn't contain the correct Expression**s, but this is
   // left in for future improvements. TODO.
   ReachingDefinitionsTransferFunction(Function* func,
-                                      LocalGraph::GetSetses& getSetses,
+                                      LocalGraph::GetSetsMap& getSetsMap,
                                       LocalGraph::Locations& locations)
-    : numLocals(func->getNumLocals()), getSetses(getSetses),
+    : numLocals(func->getNumLocals()), getSetsMap(getSetsMap),
       lattice(listLocalSets(func, fakeInitialValueSets, fakeSetPtrs)) {
 
     // Map every local index to a set of all the local sets which affect it.
@@ -129,9 +129,9 @@ public:
         if (lattice.exists(currState, setInstance)) {
           // If a pointer to a real LocalSet, add it, otherwise add a nullptr.
           if (fakeSetPtrs.find(setInstance) == fakeSetPtrs.end()) {
-            getSetses[curr].insert(setInstance);
+            getSetsMap[curr].insert(setInstance);
           } else {
-            getSetses[curr].insert(nullptr);
+            getSetsMap[curr].insert(nullptr);
           }
         }
       }