diff options
author | Alon Zakai <azakai@google.com> | 2020-10-20 10:46:20 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-10-20 10:46:20 -0700 |
commit | 3732f36ce062c3ee60413e4c19667f256b9297f8 (patch) | |
tree | 538e064e695bbc310418ce2792cb52ce32acdb03 /src/passes/MemoryPacking.cpp | |
parent | e0d092b1ad26e7ef4069e31807f7c76a9eb20587 (diff) | |
download | binaryen-3732f36ce062c3ee60413e4c19667f256b9297f8.tar.gz binaryen-3732f36ce062c3ee60413e4c19667f256b9297f8.tar.bz2 binaryen-3732f36ce062c3ee60413e4c19667f256b9297f8.zip |
Warn on memory segment overlaps (#3257)
We may fix this eventually, but it appears to not be urgent. For now at least
show a warning so toolchains have a chance to see there is something
they should fix.
Diffstat (limited to 'src/passes/MemoryPacking.cpp')
-rw-r--r-- | src/passes/MemoryPacking.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/passes/MemoryPacking.cpp b/src/passes/MemoryPacking.cpp index 3ab170ea9..6003274e8 100644 --- a/src/passes/MemoryPacking.cpp +++ b/src/passes/MemoryPacking.cpp @@ -232,6 +232,8 @@ bool MemoryPacking::canOptimize(const std::vector<Memory::Segment>& segments) { Address start = c->value.getInteger(); DisjointSpans::Span span{start, start + segment.data.size()}; if (space.addAndCheckOverlap(span)) { + std::cerr << "warning: active memory segments have overlap, which " + << "prevents some optimizations.\n"; return false; } } |