diff options
| author | Alon Zakai <alonzakai@gmail.com> | 2019-01-23 16:15:38 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-01-23 16:15:38 -0800 |
| commit | 119525ea6078c9af697de0038407ab541f3d4c12 (patch) | |
| tree | 16aa2f609ab96975ceb8862e3ece7baaa05f5828 /src/tools/optimization-options.h | |
| parent | e63c4a7d04c145dafaf4b09de5f9f5de69cee8ef (diff) | |
| download | binaryen-119525ea6078c9af697de0038407ab541f3d4c12.tar.gz binaryen-119525ea6078c9af697de0038407ab541f3d4c12.tar.bz2 binaryen-119525ea6078c9af697de0038407ab541f3d4c12.zip | |
Validate unique local names, and use validation in wasm2js. Fixes #1885 (#1886)
* Also fixes some bugs in wasm2js tests that did not validate.
* Rename FeatureOptions => ToolOptions, as they now contain all the basic stuff each tool needs for commandline options (validation yes or no, and which features if so).
Diffstat (limited to 'src/tools/optimization-options.h')
| -rw-r--r-- | src/tools/optimization-options.h | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/src/tools/optimization-options.h b/src/tools/optimization-options.h index 7849be375..53fd60e4d 100644 --- a/src/tools/optimization-options.h +++ b/src/tools/optimization-options.h @@ -14,7 +14,7 @@ * limitations under the License. */ -#include "feature-options.h" +#include "tool-options.h" // // Shared optimization options for commandline tools @@ -22,12 +22,12 @@ namespace wasm { -struct OptimizationOptions : public FeatureOptions { +struct OptimizationOptions : public ToolOptions { static constexpr const char* DEFAULT_OPT_PASSES = "O"; std::vector<std::string> passes; - OptimizationOptions(const std::string& command, const std::string& description) : FeatureOptions(command, description) { + OptimizationOptions(const std::string& command, const std::string& description) : ToolOptions(command, description) { (*this).add("", "-O", "execute default optimization passes", Options::Arguments::Zero, [this](Options*, const std::string&) { @@ -92,11 +92,6 @@ struct OptimizationOptions : public FeatureOptions { [this](Options* o, const std::string& argument) { passOptions.shrinkLevel = atoi(argument.c_str()); }) - .add("--no-validation", "-n", "Disables validation, assumes inputs are correct", - Options::Arguments::Zero, - [this](Options* o, const std::string& argument) { - passOptions.validate = false; - }) .add("--ignore-implicit-traps", "-iit", "Optimize under the helpful assumption that no surprising traps occur (from load, div/mod, etc.)", Options::Arguments::Zero, [this](Options*, const std::string&) { |