| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
| |
Fixes #2139
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes wasm2c serialize each function type, rather than registering
function types at module-initialization time. The serialized function
type is the SHA-256 of the mangled param and result types (with a space
between params and results).
At runtime in call_indirect, a known (immediate) function type is
compared against the function type stored in a funcref structure. For
call_indirects to functions local to the module, or for any
call_indirect when the toolchain merges string constants across
compilation units (generally, GCC and clang), this can be done by
comparing the pointers to each function type. Otherwise, the actual
32-byte values are compared.
The function type IDs can be looked up at runtime with
`Z_[modname]_get_func_type`, which matches the API from
`wasm_rt_register_func_type`. A new `callback` example demos this.
wasm2c does the SHA-256 either by linking against libcrypto or, if not
available or if requested via `cmake -DUSE_INTERNAL_SHA256=ON`, by using
a vendored (header-only) PicoSHA2. There is no runtime dependency on
SHA-256 in the wasm2c runtime or generated modules.
This eliminates the last of the per-module state, so this commit also removes
the [modname]_init_module() function and the s_module_initialized bool.
|
| |
|
|
|
|
| |
I'm not sure this was ever needed. `__inline` and `inline` are
identical under msvc:
https://learn.microsoft.com/en-us/cpp/cpp/inline-functions-cpp?view=msvc-170
"The __inline keyword is equivalent to inline"
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
Value's `type` field was compiled conditionally on the `NDEBUG` define.
This causes problems with programs compiling against libwabt that don't
define this macro, as the Value layout no longer matches.
Using a condition in config.h.
Fixes #2069
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Use standard modules to test endianness
CMake prior to v3.20 provides a module TestBigEndian which we can use to
set the WABT_BIG_ENDIAN define. As of 3.20, the CMAKE_<LANG>_BYTE_ORDER
variable should be preferred. Leaving this as a note for the future.
* Fix x87 math detection
TARGET_ARCH was only used to determine whether to add gcc-specific SSE
math flags (-msse2 -mfpmath=sse). The new approach simply assumes gcc
compatibility with its __i386__ and __SSE2_MATH__ symbols, which are
defined precisely when we are targeting x86-32 with SSE2 math enabled.
If those macros are defined, then we conclude all is well. Otherwise, we
add the flags if we know the compiler is gcc or clang (and will thus
accept them) and issue a warning if the compiler is unknown.
Fixes #1709
Fixes #1688
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Rename CMAKE_PROJECT_VERSION to WABT_VERSION_STRING
CMAKE_PROJECT_VERSION is a standard variable that is controlled by the
project() command. Renaming our usage to WABT_VERSION_STRING better
describes the purpose of the variable and avoids surprises down the
line.
* Use git describe output to annotate version string
Before this commit, the attempt to add the output of git describe to the
version string printed by $wasm-tool --version was bugged. It would
always print the three-part version number (like 1.0.29).
After this commit, the output of `git describe --tags` is used to append
a description to the version number in the form of: "ver (git~desc)".
For example:
$ ./wasm2c --version
1.0.29 (git~1.0.29-27-gf63184ef)
If this command returns a tag equal in name to the current version,
nothing is appended.
If this command fails, a NOTICE (rather than a WARNING) is printed (only
if the project is top-level), and only the bare version number is used.
If the source code is not living in the git repository then, again, only
the bare number is used, but no warning is printed.
Fixes #1977
Fixes #1978
|
| | |
|
| |
|
| |
This is designed to exactly mimic the definition that LLVM uses under MSVC; this allows use of both WABT and LLVM headers in the same codebase without having to work around compilation errors.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's modeled closely on the wasm-c-api. All runtime objects are
garbage-collected. The GC'd objects are subclasses of `Object` and all
stored in the `Store`. GC roots can be created using a RefPtr<T> struct.
The `Module` stores no runtime objects, only description structs (named
`*Desc`, e.g. `FuncDesc`). Instantiation takes these descriptors and
turns them into runtime objects (e.g. `FuncDesc` is used to create a
`Func`). Only import-matching occurs during instantiation; all other
validation is assumed to have occurred during Module compilation.
As with the previous interpreter, the wasm instructions are not executed
directly, and instead compiled to an instruction stream that is easier
to interpret (e.g. all branches become gotos). It's still a stack
machine, though.
The previous interpreter would always compile and instantiate in one
step, which means that it was always known whether an imported function
is a host function or wasm function. As a result, calls between modules
that stayed in wasm could be very cheap (just update PC). Now that the
module is compiled before instantiation, an imported function call
always has to check first, which may be a slight performance hit.
One major difference to the structure of the interpreter is that
floating-point values are passed directly, instead of using their
equivalent bit pattern. This is more convenient in general, but requires
annotating all functions with WABT_VECTORCALL so Visual Studio x86 works
properly (otherwise floats are passed in the x87 FP stack).
Instruction stream decoding/tracing/disassembling is now all handled in
the `Istream` class. This reduces a lot of duplication between the
three, which makes the logging-all-opcodes and tracing-all-opcodes less
valuable, so I've removed them.
Here are the changes to files:
binary-reader-metadata.{h,cc} -> [removed]
interp-{disassemble.trace}.cc -> istream.{h,cc}
There are new helper files:
interp-util.{h,cc}: Primarily print debugging functions
interp-math.h: Templates used for handling wasm math
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Use _POSIX_C_SOURCE where applicable
Use _POSIX_C_SOURCE=200809L everywhere except MSVC.
For MinGW, it should have same effect in regard of
`__USE_MINGW_ANSI_STDIO`.
For Cygwin, it will allow to use POSIX APIs under `-std=c++11`
environment.
* binary-reader-objdump.cc: #include <strings.h>
Include `strings.h` because it depends POSIX strcasecmp.
* Disable `CMAKE_CXX_EXTENSIONS` explicitly
Explicitly disable `CMAKE_CXX_EXTENSIONS` which is ON by default in
recent CMake(>= 3.1) which will read implicit `-std=gnu++11` injection.
* test-hexfloat: Use <thread> instead of sysconf
Use <thread> instead of sysconf which is a bit more "standard" way to do
this.
* Guard <strings.h> with HAVE_STRCASECMP
Guard `strings.h` with `HAVE_STRCASECMP` because non-POSIX platform may
not have it.
|
| |
|
|
|
|
| |
Add VERSION to project command, which in turn required a cmake
version bump to 3.0.0.
Fixes: #1314
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Closes: #1106
Ported versioning system from [Binaryen CMakeLists.txt](https://github.com/WebAssembly/binaryen/blob/dc31b460fef47dfb3415b4ae6276fff4919a03e2/CMakeLists.txt#L10-L23)
```
bin/wasm2c --version
1.0.11-44-g71f883ad
```
Applied to (all) tools in `src/tools/`.
|
| |
|
|
|
|
|
|
| |
Using __builtin_unreachable instead will basically produce undefined
behavior if it is ever reached, which makes it very difficult to debug.
This is perhaps desired for an optimized build, but certainly not for a
debug build.
For now, we'll always convert these to abort().
|
| |
|
|
|
| |
* Remove passive keyword from bulk-memory
* Fix rounding on hex floats
* Allow underscores in NaN payloads
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
`Opcode::FromCode` calculated the opcode given a prefix/code pair by
using lower_bound over the list of all `OpcodeInfo`s. This was happening
for every instruction, which is incredibly slow.
Since the interpreter's format is internal only, we can use any encoding
we want, so it's simpler and faster to use the `Opcode::Enum` directly
without calling `Opcode::FromCode`.
`Opcode::FromCode` is also used when reading a binary file, so it should
be optimized anyway. Instead of using the `infos_` table, which is
indexed by the opcode's `enum_` value, we create a new
statically-defined table that maps from prefix-code pair to its enum
value.
Unfortunately, this can't be done easily in C++ because it does not
currently support designated array initializers, so this table is
created in a C file instead, `opcode-code-table.c`.
|
| |
|
| |
This was recently changed in emscripten. It seems that ssize_t can be used directly now, so defining it is only necessary for MSVC.
|
| |
|
| |
Resolves #864
|
| |
|
|
| |
Remove _Check_Return_ annotation on Windows because that annotation must be a prefix to the function not a suffix which was breaking the code analysis on binary-reader.cc.
Couldn't find a way to reconcile clang/gcc/msvc to all use a prefix or suffix for that annotation, furthermore it is not used a lot in the project anyway.
|
| |
|
|
| |
I also fixed some for/if to use braces if I noticed it. This is a
non-functional change.
|
| |
|
|
|
|
|
| |
Including:
f32x4.convert_s/i32x4
f32x4.convert_u/i32x4
f64x2.convert_s/i64x2
f64x2.convert_u/i64x2
|
| |
|
|
|
|
|
| |
Put them in the `wabt` namespace and follow the normal naming convention
(MixedCase).
More importantly, these are now defined for all inputs, instead of using
`__builtin_c[tl]z*` directly which are undefined for 0.
|
| |
|
|
|
|
|
|
| |
This is currently only supported where VT100 escape sequences work. We
assume that if `isatty` is true then color will be supported. This logic will
likely need to be improved, but this is a good start.
This PR also adds support for passing an environment variable to a test
via `ENV`. This is used to test the `FORCE_COLOR` environment variable.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add fuzzing helper scripts, fix fuzzing bugs
The fuzzing dictionary was old, so I updated it. Also, I've added some
simple fuzzing shell scripts that make it a bit easier to run.
Bug fixes:
* Validate function index in local name section before calling callback.
* Fix invalid assert in parse_{float,double}_infinity, which assumed
that "infinity" is required (it could be "inf").
* Bail out of resolve local names if there is no current function (e.g.
if attempting to resolve names in an elem offset expression).
* Catch bad_alloc in wast2wasm and wasm2wast. Without this, afl-fuzz
will see allocation failure as a crash.
* disable exceptions by default, add option, wrap tools in try/catch
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes issue #326.
* Install target installs all executables; this is required because we don't
actually know where MSVC builds its targets to
* Use absolute paths when running all executables
* Set `PYTHONPATH` to test directory; for some reason the Windows `sys.path`
doesn't include the current script's directory
* In `wasmdump`, strip the directory up to the last slash or backslash
* In `wasm-interp`, Use round-to-nearest-ties-to-even when converting from
uint64 to float or double
* Check for backslash or slash in `get_dirname` in `wasm-interp`, when looking
for modules alongside the JSON file
* print floats in `wasm-interp` using `%f` not `%g`, since MSVC prints using 3
digits for exponent instead of 2
* In `run-wasm-link.py`, remove file before renaming on top of it
|
| |
|
|
|
|
|
|
|
|
|
| |
mingw32 tries to support both VC runtime printf and a POSIX-compliant
printf. It seems to randomly choose between the two, depending on
arbitrary factors like header include order. This change forces us to
always use the POSIX-compliant printf on mingw, and also changes the
WABT_PRINTF_FORMAT attribute to use the POSIX-compliant tag too
(gnu_printf, since printf defaults to ms_printf).
This seems to resolve the issues for #324, as well as the ones I found
in #342 as well.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mostly this involves adding additional casts. Though there are a few
more substantial changes:
* The default method for relocating parser stacks no longer works
because Bison assumes that C++ values can't be memcpy'd. Ours can, but
there's no easy way to make the generated code do the right thing, so
we do it manually
* Removed all uses of WabtBool and replaced with bool
* Renamed all uses of export and mutable -> export_ and mutable_
* Casting an invalid value to an enum triggers ubsan, so we have to be a
little more careful about when we do it (see binary-reader.c:read_sections())
* It's illegal to forward-declare enums, so we just #include instead.
* Designated initializers are not allowed in g++, so we have to switch
them to lazily initialized structures instead. Pretty horrible, so it
will be nice to have a better solution for C++.
|
| | |
|
| |
|
| |
This should fix issue #262.
|
| |
|
