summaryrefslogtreecommitdiff
path: root/src/wat-writer.cc
Commit message (Collapse)AuthorAgeFilesLines
* binary/wat: Implement EHv4 (#2470)Soni L.2024-11-201-0/+106
| | | | This pull request implements EHv4. Binary is mostly untested until interp is working.
* Add support for the custom-page-sizes proposal (#2502)Keith Winstein2024-11-081-0/+5
| | | | This adds support in the binary/text parsers and writers, the validator and interpreter, and objdump (but not wasm2c).
* wat-writer.cc: update text serialization of data memuse (#2501)Keith Winstein2024-11-071-1/+5
|
* Implement custom section reading/writing (#2284)Diego Frias2023-09-151-0/+13
|
* Flip order of memory indexes on memory.copy (#2294)Keith Winstein2023-09-111-1/+1
| | | | Reflects change in the multi-memory proposal: https://github.com/WebAssembly/multi-memory/pull/29
* wat-writer.cc: resolve missing type index in call_indirect (#2278)Keith Winstein2023-07-311-2/+10
|
* Silence warnings on GCC 12 (#2177)Keith Winstein2023-03-221-1/+1
| | | Fixes #2020
* Always do a full roundtrip in run-roundtrip.py (#1661)Sam Clegg2023-02-281-1/+9
| | | | | | | | | | | | | | | | Even when the result is to be printed rather than compared byte for byte with the first version its still good to process the resulting wat output file so that we know we can parse what we generate. Case in point, this changed caused me to fix two latent bugs: 1. We were not correctly parsing events with inline import/export. 2. We were output element segment names even when bulk memory was not enabled (See #1651) The fix for (2) is a little more involved that we might like since for the first time the wat writer needs to know what features are enabled. Fixes: #1651
* Move headers to include/wabt/ (#1998)Alex Reinking2022-09-281-9/+9
| | | This makes things easier for users and packagers of libwabt.
* Support multi-memory in all memory ops and in apply/resolve-names (#1962)Keith Winstein2022-08-151-0/+2
|
* Track locations of Vars in BinaryReaderIR and BinaryReaderInterp (#1963)Keith Winstein2022-08-151-1/+1
| | | | - Rebase test output to match new location tracking on Vars - Eliminate single-argument Var() constructor.
* Add initial support for code metadata (#1840)Yuri Iozzelli2022-02-251-0/+11
| | | | | | | | | | | | | | | | | | | | | See https://github.com/WebAssembly/tool-conventions/blob/main/CodeMetadata.md for the specification. In particular this pr implements the following: - Parsing code metadata sections in BinaryReader, providing appropriate callbacks that a BinaryReaderDelegate can implement: - BinaryReaderObjdump: show the sections in a human-readable form - BinaryReaderIr: add code metadata in the IR as expressions - Parsing code metadata annotations in text format, adding them in the IR like the BinaryReaderIR does - Writing the code metadata present in the IR in the proper sections when converting IR to binary - Support in wasm-decompiler for showing code metadata as comments in the pseudo-code All the features have corresponding tests. Support for code metadata is gated through the --enable-code-metadata feature. For reading/writing in the text format, --enable-annotations is also required. Missing features: Support for function-level code metadata (offset 0) Extensive validation in validator.cc (like making sure that all metadata instances are at the same code offset of an instruction)
* Use C++17 string_view (#1826)Sam Clegg2022-02-111-6/+6
| | | | | Now that we have C++17 we don't need our own string_view class anymore. Depends on #1825
* Clang-format codebase (#1684)Heejin Ahn2021-12-201-8/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This applies clang-format to the whole codebase. I noticed we have .clang-format in wabt but the codebase is not very well formatted. This kind of mass-formatting PR has fans and skeptics because it can mess with `git blame`, but we did a similar thing in Binaryen a few years ago (WebAssembly/binaryen#2048, which was merged in WebAssembly/binaryen#2059) and it was not very confusing after all. If we are ever going to format the codebase, I think it is easier to do it in a single big PR than dozens of smaller PRs. This is using the existing .clang-format file in this repo, which follows the style of Chromium. If we think this does not suit the current formatting style, we can potentially tweak .clang-format too. For example, I noticed the current codebase puts many `case` statements within a single line when they are short, but the current .clang-format does not allow that. This does not include files in src/prebuilt, because they are generated. This also manually fixes some comment lines, because mechanically applying clang-format to long inline comments can look weird. I also added a clang-format check hook in the Github CI in #1683, which I think can be less controversial, given that it only checks the diff. --- After discussions, we ended up reverting many changes, especially one-liner functions and switch-cases, which are too many to wrap in `// clang-format off` and `// clang-format on`. I also considered fixing `.clang-format` to allow those one-liners but it caused a larger churn in other parts. So currently the codebase does not conform to `.clang-format` 100%, but we decided it's fine.
* Fix type names for function references (#1787)Sam Clegg2021-12-131-3/+1
| | | | | | | | This requires `Type::GetName` to return to be dynamicllay created and return `std::string` rather then a `const char*` As this diff shows this type name is only used in textual output and error messages so should this change should not have a effect of binary parse time or the interpreter.
* Add multi-memory feature support (#1751)Yuhan Deng2021-11-301-7/+60
|
* Delay validation of elem init expressions until validation time (#1730)Sam Clegg2021-10-141-12/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Doing validation at parse time means we cannot run tests which included invalid instruction in the elem init expressions. For example. the updated test suite repo contains tests such as this: ``` (assert_invalid (module (table 1 funcref) (elem (i32.const 0) funcref (item (i32.add (i32.const 0) (i32.const 1)))) ) "constant expression required" ) ``` There we have an illegal instruction sequence in the init expresssion. However, in order to run this test we need to be able to process it with wast2json first which means it at least has to parse correctly. This change removes the `ElemExpr` and `ElemExprKind` types from the IR and instead just stores elem init expressions as `ExprList` like we do for global init expressions. This expression list can then be validated but crucially can also be invalid. This technique matches the existing `OnDataSegmentInitExpr_Other` and `OnGlobalInitExpr_Other` and indeed it seem that it was indented to work this way since the `OnElemSegmentElemExpr_Other` already existed (unused) in the codebase.
* Begin support for typed function references proposal: added the flag and ↵Dmitry Bezhetskov2021-07-251-0/+7
| | | | supported call_ref (#1691)
* Allow plain `try` with no `catch` or `delegate` (#1676)Asumu Takikawa2021-06-291-2/+2
| | | | | | Matches recent changes in the exception handling spec that allowed this case to reduce special cases in the syntax: https://github.com/WebAssembly/exception-handling/pull/157
* [EH] Remove `unwind` (#1682)Heejin Ahn2021-06-291-17/+0
| | | `unwind` was removed. See WebAssembly/exception-handling#156.
* Fix try-delegate label printing (#1685)Asumu Takikawa2021-06-291-0/+1
| | | | | | | This is similar to a previous bug (#1609) for other kinds of block labels. The tests check that 2+ adjacent try-delegate blocks will have labels that print correctly. (split from #1675)
* [EH] Replace event with tag (#1678)Heejin Ahn2021-06-221-19/+19
| | | | | | | | | | | We recently decided to change 'event' to 'tag', and 'event section' to 'tag section', out of the rationale that the section contains a generalized tag that references a type, which may be used for something other than exceptions, and the name 'event' can be confusing in the web context. See - https://github.com/WebAssembly/exception-handling/issues/159#issuecomment-857910130 - https://github.com/WebAssembly/exception-handling/pull/161
* [simd] Implement store lane (#1647)Ng Zhi An2021-03-221-0/+15
|
* [simd] Implement load lane (#1646)Ng Zhi An2021-03-221-0/+14
| | | | | | | | | This is a new kind of ir/ast node/instruction. It has 3 immediates: memarg align, memarg offset, and lane index. This required new visitor functions in all the places. Drive-by cleanup to share the simd lane parsing logic between shuffle, lane op and this new load lane instructions. This requires rebasing some tests because the error messages are slightly different now.
* [simd] Implement v128.load{32,64}_zero (#1644)Ng Zhi An2021-03-171-0/+6
| | | | This requires a new ir type, and the relevant implementation of virtual mthods in the various visitors.
* Fix label printing for blocks in folded form (#1609)Asumu Takikawa2021-02-231-0/+4
| | | | This makes labels consistent with non-folded printing when multiple blocks are in function or block body.
* Update rethrow depth handling and catch_all opcode (#1608)Asumu Takikawa2021-02-181-3/+1
| | | | | | | | | | | | | Give `catch_all` its own opcode: Previously `catch_all` shared an opcode with `else`, but the spec now allocates it the 0x19 opcode. Adjust rethrow depth semantics: Previously this had interpreted the rethrow depth argument as counting only catch blocks, but the spec has clarified that it should count all blocks (in a similar fashion as `br` and related instructions).
* Update exception handling support to current proposal (#1596)Asumu Takikawa2021-02-101-17/+64
| | | | | | | | | | This PR updates the support of exception handling to the latest proposal (that is compatible with future 2-phase exception handling) described in https://github.com/WebAssembly/exception-handling/pull/137 and https://github.com/WebAssembly/exception-handling/pull/143. * Adds back tagged `catch $e`, `catch_all`, and `rethrow N` from a previous version of wabt, but with updates to match the current spec (e.g., `catch_all` shares an opcode with `else`, `rethrow`'s depth indexes only catch blocks, etc). * Adds `unwind` and `delegate` instructions. * Removes `exnref` and `br_on_exn`. * Updates relevant tests. There are some details that could still change (e.g., maybe how `delegate`'s depth is validated), but I'd be happy to submit further PRs if the spec details change.
* Port to big-endian platforms (s390x but others can be trivially added) (#1557)Soni L2020-12-071-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Initial attempt at s390x port * Second attempt at s390x port * Fix big-endian memory fill * Fix more memory location calculations * Improve SIMD * Implement big-endian memory grow * Fill relocation with 0x00, as per spec * Make wasm2c endianness work * Fix shuffle * Fix load endianness in wasm2c * Refactor into shared code * Clean up SwapBytesSized * Clean up MemcpyEndianAware * Clean up * "Fix" opcodecnt basic test
* Changes required to make the new Memory64 spec tests run (#1560)Wouter van Oortmerssen2020-10-261-3/+3
| | | | | These uncovered some things the previous tests didn't! Also required the switching of the location of the index as discussed in https://github.com/WebAssembly/memory64/issues/5 Also one small .py change that ensures the new tests have consistent posix paths.
* Enable -Werror during CI (#1522)Sam Clegg2020-08-181-2/+2
| | | | Fixes: #1249
* Made the interpreter "type-safe" in debug mode (#1512)Wouter van Oortmerssen2020-08-101-2/+2
| | | | | Adds a type field to `Value` to verify the right union member is being read. A Wasm module that has been validated shouldn't need this, but any code reading the wrong value would trigger UB, but still often work (like a uint32_t read from a uint64_t on little endian machine), and mask bugs. Turning this on found bugs in the PR I just landed (as I suspected) but also in older code.
* Added initial "memory64" proposal support (#1500)Wouter van Oortmerssen2020-08-071-0/+3
|
* Print newline after rethrow instruction (#1503)Asumu Takikawa2020-07-301-1/+1
|
* Print newline after ref.is_null instruction (#1495)Ben Smith2020-07-241-1/+1
|
* Remove ref.is_null type parameter (#1474)Ben Smith2020-07-151-1/+0
| | | | | | | | | See https://github.com/WebAssembly/reference-types/issues/99. This change also updates the testsuite, so the spec tests pass too. In addition, the behavior of `br_table` is no longer different from MVP, and has a text to confirm this. That is now fixed in `type-checker.cc` too.
* [wasm2wat] Fix a few more roundtripping issues (#1450)Ben Smith2020-05-291-1/+1
| | | | | | | * The `declare` keyword should be printed when using element expressions or element indexes (i.e. flags == 3 or flags == 7). * An imported table was not properly setting the element type in the IR Fixes #1448 and #1449.
* [wasm2wat] Write select type immediate (#1451)Ben Smith2020-05-291-1/+5
| | | | | | | | | | | | | | | The main fix is in `wat-writer.cc`, where the type immediate was never being printed. But I've also included a change to how `select` type immediates are represented in wabt. Previously, a bare `select` instruction would be stored with the type `Type::Any`. This is not a real wasm type, and is primarily used for type validation. The spec instead considers this form of `select` to have an empty type immediate, which is closer to the `Type::Void` type. This commit now uses `Type::Void` (or an empty `TypeVector`) to represent the bare `select` instruction. Fixes #1444.
* [wat2wasm] Write table indexes in text format (#1446)Ben Smith2020-05-281-4/+25
| | | | | | | | | | | | * [wasm2wat] Write table index when non-zero It was already being properly written to binary, and read from binary into IR. It just wasn't been written out to wat. Fixes #1443. * Also write table indexes for table.{init,copy} Fixes #1445
* Reference types changes to remove subtyping (#1407)Ben Smith2020-05-281-3/+11
| | | | | | | | Main changes: * Rename `anyref` -> `externref` * Remove `nullref` * Rename `hostref` -> `externref` * `ref.null` and `ref.is_null` now have "ref kind" parameter * Add ref kind keywords: `func`, `extern`, `exn`
* Require `do` in folded `try` statement (#1425)Ben Smith2020-05-141-0/+2
| | | | | | | | | | | | | For example: ``` (try $label (param ...) (result ...) (do ...) (catch ...) ) ``` See comment here: https://github.com/WebAssembly/exception-handling/issues/52#issuecomment-626696720
* Fix bug when writing grouped named parameters (#1418)Ben Smith2020-05-131-11/+12
| | | | | | | | | | A named parameter (or local) must always be in its own `param` block, so this syntax is not allowed: `(param i32 $b i32)` And must instead be converted to: `(param i32) (param $b i32)`
* Add support for atomic.fence from the threads proposal (#1231)Andy Wingo2020-04-201-0/+8
| | | | | See https://github.com/WebAssembly/threads/pull/141 for the binary encoding. This patch does add a field to AtomicFenceExpr for the consistency model, though without a type for the time being.
* Parse ArrayTypes (#1364)Ben Smith2020-03-231-7/+20
| | | | | | | | | | The following formats are supported: * (type (array i32)) * (type (array (field i32))) * (type (array (field (mut i32)))) This PR adds support for reading/writing binary and text, but no interpreter support yet.
* Fix whitespace formatting of SIMD ops (#1372)Adam Klein2020-03-231-3/+3
| | | Fixes #1227.
* Move more functionality into the v128 type (#1363)Ben Smith2020-03-201-2/+2
| | | | | | | | | * Add lane getters: u{8,16,32,64}, f{32,64}_bits * Add lane setters: set_u{8,16,32,64}, set_f{32,64}_bits * Add set_zero, is_zero * Add To<Type>() and From<Type>() These changes will make it easier to build v128 values in the spectest-interp (which needs to be updated to support SIMD spec tests)
* Refactor Const struct's internal storage (#1356)Ben Smith2020-03-161-14/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Const previously stored each value as a union of bit patterns (uint32_t, uint64_t, v128, etc). It was then extended to support cases where NaN value (either arithmetic or canonical) was expected. bool is_expected_nan; union { uint32_t u32; uint32_t f32_bits; ... ExpectedNan expected; } With the SIMD proposal, it's possible for each lane of a f32x4 or f64x2 to be a float or an expected NaN, so this doesn't work anymore. It's possible to move ExpectedNan out of the union, but it's a bit clumsy to use properly: bool is_expected_nan[4]; ExpectedNan expected[4]; union { ... } Instead, I took this as an opportunity to clean up the class a bit. First, ExpectedNan is extended to handle the case where it is not a NaN (i.e. not a not a number), which allows us to remove the bool. Then I store the rest of the data as an array of `uint32_t`, and provide accessor functions instead.
* Parse struct fields (#1355)Ben Smith2020-03-161-3/+18
| | | | | | | | | | | This allows the following field formats: * `(struct (field $name i32))` * `(struct (field $name (mut i32)))` * `(struct (field i32))` * `(struct (field (mut i32)))` * `(struct (mut i32))` * `(struct i32)`
* Initial pass parsing/reading struct (#1352)Ben Smith2020-03-091-10/+19
| | | | | | | | | | | | | | | | | | This parses just the format `(struct)` as a new type. I added a test for this using `wat2wasm`, but that requires a rudimentary binary format. The test runner automatically attempts to rountrip all wat2wasm tests, so this required implementing the wat writing and binary reading too. Here's a summary of the changes: * binary-reader:h: Rename `BinaryReader::OnType` callbacks to `OnFuncType` * binary-reader.h: Add `BinaryReader::OnStructType` * binary-reader.cc: Use a switch after reading the type form to determine whether we're reading a function or struct. * tokens.def: Add new `TokenType::Struct` * lexer-keywords.txt: Add new `struct` keyword * type.h: Add `Type::Struct` type form * wast-parser.cc: Parse `(struct)` in text format * wat-writer.cc: Write Func or Struct type forms
* Convert Type from an enum into a class (#1350)Ben Smith2020-02-281-1/+1
| | | | | | | | | | | | | | | | | This is similar to the way Opcode is structured, which allows us to hang member functions off of the enumeration. The primary motivator for this change is the GC proposal (and the function-references proposal) where a Type can be parameterized: (type $T (struct ...)) (func (local (ref $T) ... ) In this case the type is ref, with a parameter of the type index. Making Type a class will make it easier to store this additional information.
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-04 18:48:09 +0000